[flutter_adaptive_scaffold] : 🐛 : #110902 : Assertion added when try with less that 2 destinations. #6360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gspencergoog
approved these changes
Mar 21, 2024
packages/flutter_adaptive_scaffold/lib/src/adaptive_scaffold.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: Greg Spencer <[email protected]>
aliasgar4558
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 22, 2024
…en try with less that 2 destinations. (flutter/packages#6360)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 22, 2024
…en try with less that 2 destinations. (flutter/packages#6360)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 22, 2024
flutter/packages@b7fbe68...611aea1 2024-03-21 [email protected] Roll Flutter from b96c13d to 18340ea (26 revisions) (flutter/packages#6370) 2024-03-21 [email protected] Roll Flutter (stable) from ba39319 to 68bfaea (2 revisions) (flutter/packages#6368) 2024-03-21 [email protected] [flutter_adaptive_scaffold] Remove broken link from README (flutter/packages#6364) 2024-03-21 [email protected] [adaptive_scaffold] : � : #110902 : Assertion added when try with less that 2 destinations. (flutter/packages#6360) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
…s that 2 destinations. (flutter#6360) *Issue : flutter/flutter#110902 Changes included in PR are listed as follows - As `NavigationRail` & `NavigationBar` etc has assertion which won't allow less than 2 destinations, Similar assertion added in "AdaptiveScaffold" to acknowledge users regarding the same with a user friendly message. - CHANGELOG.md file updated. - Updated to v0.1.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : flutter/flutter#110902
Changes included in PR are listed as follows
NavigationRail&NavigationBaretc has assertion which won't allow less than 2 destinations, Similar assertion added in "AdaptiveScaffold" to acknowledge users regarding the same with a user friendly message.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).If you need help, consider asking for advice on the #hackers-new channel on [Discord].