Reverts "[interactive_media_ads] Creates and adds the interactive_media_ads plugin (#6060)"
#6417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![auto-submit[bot]](https://avatars.githubusercontent.com/u/14101776?s=60&v=4){kind=small}
auto-submit
bot
added
the
revert of
fluttergithubbot
approved these changes
Mar 28, 2024
auto-submit
bot
deleted the
revert_72669d5eed65f850c91a297dc75e2b80cd960cf3
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 28, 2024
…ctive_media_ads` plugin (flutter#6060)" (flutter/packages#6417)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 28, 2024
…ctive_media_ads` plugin (flutter#6060)" (flutter/packages#6417)
Merged
11 tasks
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 28, 2024
flutter/packages@e6b3e11...924c7e6 2024-03-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ci] Temporarily allow-warnings in podspec_check_command.dart (#6416)" (flutter/packages#6419) 2024-03-28 [email protected] [ci] Temporarily allow-warnings in podspec_check_command.dart (flutter/packages#6416) 2024-03-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[interactive_media_ads] Creates and adds the `interactive_media_ads` plugin (#6060)" (flutter/packages#6417) 2024-03-27 [email protected] [interactive_media_ads] Creates and adds the `interactive_media_ads` plugin (flutter/packages#6060) 2024-03-27 [email protected] [camerax] Use `AspectRatioStrategy` to help automatic selection of expected resolution (flutter/packages#6357) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
philipfranchi
pushed a commit
to philipfranchi/flutter-relabel-widgets
that referenced
this pull request
Mar 28, 2024
flutter/packages@e6b3e11...924c7e6 2024-03-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ci] Temporarily allow-warnings in podspec_check_command.dart (flutter#6416)" (flutter/packages#6419) 2024-03-28 [email protected] [ci] Temporarily allow-warnings in podspec_check_command.dart (flutter/packages#6416) 2024-03-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[interactive_media_ads] Creates and adds the `interactive_media_ads` plugin (flutter#6060)" (flutter/packages#6417) 2024-03-27 [email protected] [interactive_media_ads] Creates and adds the `interactive_media_ads` plugin (flutter/packages#6060) 2024-03-27 [email protected] [camerax] Use `AspectRatioStrategy` to help automatic selection of expected resolution (flutter/packages#6357) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
…dia_ads` plugin (flutter#6060)" (flutter#6417) Reverts: flutter#6060 Initiated by: ditman Reason for reverting: This is consistently breaking in `main` with: ``` BUILD FAILED in 1m 2s 01:03 +0: loading /b/s/w/ir/x/w/packages/packages/interactive_media_ads/example/integration_test/interactive_media_ads_test.dart Running Gradle task 'assembleDebug'... 63.0s [!] App requires Multidex support ``` It probably needs something [like this](https://github.com/flutter/packag Original PR Author: bparrishMines Reviewed By: {stuartmorgan} This change reverts the following previous change: Part of flutter/flutter#134228 Initial implementation of the plugin. * Adds minimum changes to pass CI (licenses, gradle, podpec changes, etc..). * Adds platform interface and tests for it.
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
…a_ads plugin flutter#6060" (flutter#6425) Relands flutter#6060 with the addition of the `multidexEnabled` as mentioned in flutter#6417. See flutter#6417 for revert Part of flutter/flutter#134228
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #6060
Initiated by: ditman
Reason for reverting: This is consistently breaking in
mainwith:It probably needs something [like this](https://github.com/flutter/packag
Original PR Author: bparrishMines
Reviewed By: {stuartmorgan}
This change reverts the following previous change:
Part of flutter/flutter#134228
Initial implementation of the plugin.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.