[ios_platform_images] Add Swift Package Manager support #6684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
commented
May 7, 2024
| @@ -5,7 +5,7 @@ | |||
| import Flutter | |||
| import UIKit | |||
|
|
|||
| @UIApplicationMain | |||
| @main | |||
There was a problem hiding this comment.
This was updated automatically by the Flutter tool by running the example app.
loic-sharma
force-pushed
the
spm_migrate_ios_platform_images
branch
from
f493864 to
9a3ce4f
Compare
loic-sharma
force-pushed
the
spm_migrate_ios_platform_images
branch
from
43cd52c to
c074132
Compare
loic-sharma
commented
May 7, 2024
| let package = Package( | ||
| name: "ios_platform_images", | ||
| platforms: [ | ||
| .iOS("12.0") |
There was a problem hiding this comment.
I removed macOS from the platforms. Please let me know if you have concerns with this.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: configuration change (New SPM support is automatically tested by existing CI as part of enabling support.) |
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 9, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 10, 2024
flutter/packages@8de142d...6c4482a 2024-05-09 [email protected] [image_picker_ios] Adds Swift Package Manager compatibility (flutter/packages#6696) 2024-05-09 [email protected] [flutter_lints] Rev to 4.0.0; prepare for publishing (flutter/packages#6695) 2024-05-09 [email protected] [pointer_interceptor] Remove `implements` from app-facing package (flutter/packages#6699) 2024-05-08 [email protected] Temporarily add empty header files to video_player_avfoundation so include directory is downloaded (flutter/packages#6694) 2024-05-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[image_picker_ios] Adds Swift Package Manager compatibility to image_picker_ios (#6617)" (flutter/packages#6693) 2024-05-08 [email protected] [image_picker_ios] Adds Swift Package Manager compatibility to image_picker_ios (flutter/packages#6617) 2024-05-08 [email protected] [video_player_avfoundation] Adds Swift Package Manager compatibility (flutter/packages#6675) 2024-05-08 [email protected] [ios_platform_images] Add Swift Package Manager support (flutter/packages#6684) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
Adds Swift Package Manager support to `ios_platform_images`. This does not migrate the example app's Xcode project; the example app's Xcode project is migrated whenever you run it using the Flutter tool with the Swift Package Manager feature enabled. Fixes flutter/flutter#146909
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
Adds Swift Package Manager support to `ios_platform_images`. This does not migrate the example app's Xcode project; the example app's Xcode project is migrated whenever you run it using the Flutter tool with the Swift Package Manager feature enabled. Fixes flutter/flutter#146909
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Swift Package Manager support to
ios_platform_images.This does not migrate the example app's Xcode project; the example app's Xcode project is migrated whenever you run it using the Flutter tool with the Swift Package Manager feature enabled.
Fixes flutter/flutter#146909
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.