Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shared_pref]: Bump androidx.datastore:datastore from 1.0.0 to 1.1.1 in /packages/shared_preferences/shared_preferences_android/android #7306

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 5, 2024

Bumps androidx.datastore:datastore from 1.0.0 to 1.1.1.

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot requested a review from reidbaker as a code owner August 5, 2024 08:35
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Aug 5, 2024
@stuartmorgan
Copy link
Contributor

From triage: Looks like this one needs an explicit Kotlin version.

Might want to do a manual PR combined with #7305

@jmagman jmagman force-pushed the dependabot/gradle/packages/shared_preferences/shared_preferences_android/android/androidx.datastore-datastore-1.1.1 branch from 4554e8a to 32fd63a Compare December 20, 2024 05:45
@@ -2,7 +2,7 @@ group 'io.flutter.plugins.sharedpreferences'
version '1.0-SNAPSHOT'

buildscript {
ext.kotlin_version = '1.7.10'
ext.kotlin_version = '1.9.10'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reidbaker I matched this to the kotlin version in other plugins. The tests passed, are there other implications to bumping this? I didn't see anything when I looked at other PRs, like #6228 (also a minor pubspec version bump)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks safe to me. We dont tend to use cutting edge kotlin features so the biggest impact would be on apps importing this kotlin version and in the packages repo we have a legacy uber test with all of our plugins. If presubmits pass then that test would catch the issues we might expect from dependency changes like this.

@tarrinneal tarrinneal removed their assignment Jan 10, 2025
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jen, this one slipped through my system.

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 10, 2025
@auto-submit auto-submit bot merged commit 66a4d85 into main Jan 10, 2025
78 checks passed
@auto-submit auto-submit bot deleted the dependabot/gradle/packages/shared_preferences/shared_preferences_android/android/androidx.datastore-datastore-1.1.1 branch January 10, 2025 17:46
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2025
… to 1.1.1 in /packages/shared_preferences/shared_preferences_android/android (flutter/packages#7306)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 13, 2025
… to 1.1.1 in /packages/shared_preferences/shared_preferences_android/android (flutter/packages#7306)
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jan 13, 2025
flutter/packages@6554751...3c3bc68

2025-01-11 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump the test-dependencies group across 2 directories with
1 update (flutter/packages#8412)
2025-01-11 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.json:json from 20241224 to 20250107 in
/packages/in_app_purchase/in_app_purchase_android/example/android/app
(flutter/packages#8411)
2025-01-11 [email protected] Roll Flutter from
4b23b81 to 864d4f5 (50 revisions) (flutter/packages#8408)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.json:json from 20240303 to 20250107 in
/packages/in_app_purchase/in_app_purchase_android/android
(flutter/packages#8413)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.json:json from 20241224 to 20250107 in
/packages/in_app_purchase/in_app_purchase/example/android/app
(flutter/packages#8410)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump io.mockk:mockk from 1.13.13 to 1.13.14 in
/packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#8357)
2025-01-10 [email protected] Fix dependabot test-dependencies group
io.mockk regex (flutter/packages#8406)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[shared_pref]: Bump androidx.datastore:datastore from 1.0.0 to 1.1.1 in
/packages/shared_preferences/shared_preferences_android/android
(flutter/packages#7306)
2025-01-10 [email protected] [url_launcher_windows] Correct logging url
(flutter/packages#8107)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump io.mockk:mockk from 1.13.13 to 1.13.14 in
/packages/shared_preferences/shared_preferences_android/android
(flutter/packages#8358)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump the androidx group across 3 directories with 1 update
(flutter/packages#8329)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.json:json from 20240303 to 20241224 in
/packages/in_app_purchase/in_app_purchase_android/example/android/app
(flutter/packages#8372)
2025-01-10 [email protected] [url_launcher][web] Better support for
semantics in the Link widget (flutter/packages#6711)
2025-01-10 [email protected] [camera]:
Activate leak testing for sub packages (flutter/packages#8353)
2025-01-09 [email protected]
[camera_android_camerax] Remove logic used to previously correct preview
rotation (flutter/packages#8256)
2025-01-09 [email protected] [go_router]
Rephrases readme to better describe the current status
(flutter/packages#8403)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
maheshj01 pushed a commit to maheshj01/flutter that referenced this pull request Jan 15, 2025
…er#161515)

flutter/packages@6554751...3c3bc68

2025-01-11 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump the test-dependencies group across 2 directories with
1 update (flutter/packages#8412)
2025-01-11 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.json:json from 20241224 to 20250107 in
/packages/in_app_purchase/in_app_purchase_android/example/android/app
(flutter/packages#8411)
2025-01-11 [email protected] Roll Flutter from
4b23b81 to 864d4f5 (50 revisions) (flutter/packages#8408)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.json:json from 20240303 to 20250107 in
/packages/in_app_purchase/in_app_purchase_android/android
(flutter/packages#8413)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.json:json from 20241224 to 20250107 in
/packages/in_app_purchase/in_app_purchase/example/android/app
(flutter/packages#8410)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump io.mockk:mockk from 1.13.13 to 1.13.14 in
/packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#8357)
2025-01-10 [email protected] Fix dependabot test-dependencies group
io.mockk regex (flutter/packages#8406)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[shared_pref]: Bump androidx.datastore:datastore from 1.0.0 to 1.1.1 in
/packages/shared_preferences/shared_preferences_android/android
(flutter/packages#7306)
2025-01-10 [email protected] [url_launcher_windows] Correct logging url
(flutter/packages#8107)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump io.mockk:mockk from 1.13.13 to 1.13.14 in
/packages/shared_preferences/shared_preferences_android/android
(flutter/packages#8358)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump the androidx group across 3 directories with 1 update
(flutter/packages#8329)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.json:json from 20240303 to 20241224 in
/packages/in_app_purchase/in_app_purchase_android/example/android/app
(flutter/packages#8372)
2025-01-10 [email protected] [url_launcher][web] Better support for
semantics in the Link widget (flutter/packages#6711)
2025-01-10 [email protected] [camera]:
Activate leak testing for sub packages (flutter/packages#8353)
2025-01-09 [email protected]
[camera_android_camerax] Remove logic used to previously correct preview
rotation (flutter/packages#8256)
2025-01-09 [email protected] [go_router]
Rephrases readme to better describe the current status
(flutter/packages#8403)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App dependencies Pull requests that update a dependency file java Pull requests that update Java code p: shared_preferences platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants