Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump path_provider_android to ^2.2.5 due to Android v1 embedder. #7935

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

matanlurey
Copy link
Contributor

flutter/engine#52022 removed the Android v1 embedder.

I'm seeing locally that older versions of path_provider_android fail due to missing symbols:

flutter run                   
Launching lib/main.dart on sdk gphone64 arm64 in debug mode...
You are applying Flutter's main Gradle plugin imperatively using the apply script method, which is deprecated and will be removed in a future release. Migrate to applying Gradle plugins with the declarative plugins block: https://flutter.dev/to/flutter-gradle-plugin-apply

Warning: This project is still reading the deprecated '.flutter-plugins. file.
In an upcoming stable release support for this file will be completely removed and your build will fail.
See https:/flutter.dev/to/flutter-plugins-configuration.
/Users/matanl/.pub-cache/hosted/pub.dev/path_provider_android-2.2.2/android/src/main/java/io/flutter/plugins/pathprovider/PathProviderPlugin.java:39: error: cannot find symbol
      @NonNull io.flutter.plugin.common.PluginRegistry.Registrar registrar) {
                                                      ^
  symbol:   class Registrar
  location: interface PluginRegistry
1 error

FAILURE: Build failed with an exception.

To be a good citizen, let's make sure users of path_provider get a good path_provider_android.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update the min SDK version of path_provider, as the min supported SDK can't be less that the min supported SDK resolvable by a required dependency. LGTM with that change.

(We don't normally update min required versions just to "advertise" bug fixes in implementation dependencies, but we have done it for severe cases before, like when a new version of an implementation package is required for app store compliance, so it's reasonable to do here.)

@vbuberen

This comment was marked as off-topic.

@stuartmorgan

This comment was marked as off-topic.

@vbuberen

This comment was marked as off-topic.

@matanlurey
Copy link
Contributor Author

You'll need to update the min SDK version of path_provider, as the min supported SDK can't be less that the min supported SDK resolvable by a required dependency. LGTM with that change.

Done! Thanks for the suggestion.

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 29, 2024
Copy link
Contributor

auto-submit bot commented Oct 29, 2024

auto label is removed for flutter/packages/7935, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 29, 2024
@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 29, 2024
@auto-submit auto-submit bot merged commit d13a53b into main Oct 29, 2024
76 checks passed
@auto-submit auto-submit bot deleted the path-provider-min-ver branch October 29, 2024 19:31
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 30, 2024
flutter/packages@028027e...7cc1caa

2024-10-30 [email protected] [tool] Update build-all app creation (flutter/packages#7955)
2024-10-30 [email protected] Disable two lint rules which are being removed. (flutter/packages#7959)
2024-10-29 [email protected] Bump `path_provider_android` to `^2.2.5` due to Android v1 embedder. (flutter/packages#7935)
2024-10-29 [email protected] Roll Flutter from 3fb95c7 to 42132e8 (19 revisions) (flutter/packages#7958)
2024-10-29 [email protected] [webview_flutter] Fix macOS 14+ test hangs (flutter/packages#7953)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: path_provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants