-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump path_provider_android
to ^2.2.5
due to Android v1 embedder.
#7935
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to update the min SDK version of path_provider
, as the min supported SDK can't be less that the min supported SDK resolvable by a required dependency. LGTM with that change.
(We don't normally update min required versions just to "advertise" bug fixes in implementation dependencies, but we have done it for severe cases before, like when a new version of an implementation package is required for app store compliance, so it's reasonable to do here.)
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Done! Thanks for the suggestion. |
auto label is removed for flutter/packages/7935, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter/packages@028027e...7cc1caa 2024-10-30 [email protected] [tool] Update build-all app creation (flutter/packages#7955) 2024-10-30 [email protected] Disable two lint rules which are being removed. (flutter/packages#7959) 2024-10-29 [email protected] Bump `path_provider_android` to `^2.2.5` due to Android v1 embedder. (flutter/packages#7935) 2024-10-29 [email protected] Roll Flutter from 3fb95c7 to 42132e8 (19 revisions) (flutter/packages#7958) 2024-10-29 [email protected] [webview_flutter] Fix macOS 14+ test hangs (flutter/packages#7953) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/engine#52022 removed the Android v1 embedder.
I'm seeing locally that older versions of
path_provider_android
fail due to missing symbols:flutter run Launching lib/main.dart on sdk gphone64 arm64 in debug mode... You are applying Flutter's main Gradle plugin imperatively using the apply script method, which is deprecated and will be removed in a future release. Migrate to applying Gradle plugins with the declarative plugins block: https://flutter.dev/to/flutter-gradle-plugin-apply Warning: This project is still reading the deprecated '.flutter-plugins. file. In an upcoming stable release support for this file will be completely removed and your build will fail. See https:/flutter.dev/to/flutter-plugins-configuration. /Users/matanl/.pub-cache/hosted/pub.dev/path_provider_android-2.2.2/android/src/main/java/io/flutter/plugins/pathprovider/PathProviderPlugin.java:39: error: cannot find symbol @NonNull io.flutter.plugin.common.PluginRegistry.Registrar registrar) { ^ symbol: class Registrar location: interface PluginRegistry 1 error FAILURE: Build failed with an exception.
To be a good citizen, let's make sure users of
path_provider
get a goodpath_provider_android
.