Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[google_adsense] Add optional init parameters. #8297
[google_adsense] Add optional init parameters. #8297
Changes from 10 commits
3a8dca6
2aab6ad
7f3c70a
eeaca6d
bc47c6a
bb061e0
e511512
757f146
848bbf6
a11eeac
8913fe2
b09b784
af01f25
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ditman Things seem to work! This change is the only one Im not sure I completely understand, if there is someone else who can review this piece go for it, otherwise happy to jump on a 15 min call.
Approving anyways though not to be a blocker here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed because in "tap" mode (on the phone), when you click on a Flutter button that results in rendering an ad, and that button ends up behind the actuable clickable area of the button, the ad "sees" that tap event, and immediately displays the ad (they might be listening to pointer up, instead of "click" to trigger the link of the ad).
I'm adding a small timer so there's enough "time" between flutter handling the tap event, and the ad actually rendering.
This might not be the best solution, but Flutter must not be the only one affected by this, I'll bring it up to the H5 people :)