Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pigeon]: added generation of empty classes in dart #8337

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

feduke-nukem
Copy link

@feduke-nukem feduke-nukem commented Dec 21, 2024

  • Added generation of empty classes in dart
  • Removed generating data class in Kotlin if class has no fields

closes 160501

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to run the generate command dart run tools/generate.dart in the pigeon root folder before I can review this pr.

Thanks for putting this together!

packages/pigeon/CHANGELOG.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pigeon] Empty generated Dart classes aren't serializable
2 participants