-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[camera] Remove OCMock from CameraExposureTests and CameraFocusTests #8351
base: main
Are you sure you want to change the base?
[camera] Remove OCMock from CameraExposureTests and CameraFocusTests #8351
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks very good!
packages/camera/camera_avfoundation/example/ios/RunnerTests/CameraExposureTests.m
Outdated
Show resolved
Hide resolved
CC @LouiseHsu who recently did a pretty big swift migration for in-app purchase plugin. |
e7d6b59
to
c597ad3
Compare
I'm not sure why the CI build fails. Locally it builds successfully. Do you have any tip maybe what can be the cause of this issue?
|
it's been a while since i touched this, but it sounds like either module map or umbrella header. I'd look into a similar header and see how it is setup. |
I don't find a 2nd reviewer from the CODEOWNER for this plugin. Maybe @LouiseHsu who recently did a similar swift migration? |
840af1d
to
8256579
Compare
b1204d5
to
07138dc
Compare
07138dc
to
cdb1578
Compare
f7a4f92
to
3628b1f
Compare
3628b1f
to
2a070ca
Compare
d65a805
to
04f1e8b
Compare
I fixed the CI, kind of a workaround (for some reason I cannot get this to work with subfolders). I'm gonna try to fix that in further PRs, but I don't want to block this one. |
Extracted from #8342 to keep PRs smaller
FLTDeviceOrientationProviding
andFLTCaptureDeviceControlling
protocolsOCMock.h
reference fromCameraExposureTests.h
andCameraFocusTests.h
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.