Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[camera] Remove OCMock from CameraExposureTests and CameraFocusTests #8351

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

mchudy
Copy link
Contributor

@mchudy mchudy commented Dec 27, 2024

Extracted from #8342 to keep PRs smaller

  • Introduces FLTDeviceOrientationProviding and FLTCaptureDeviceControlling protocols
  • Removes OCMock.h reference from CameraExposureTests.h and CameraFocusTests.h

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@hellohuanlin hellohuanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks very good!

@hellohuanlin
Copy link
Contributor

CC @LouiseHsu who recently did a pretty big swift migration for in-app purchase plugin.

@mchudy mchudy force-pushed the feature/camera-ocmock-refactoring-part2 branch 2 times, most recently from e7d6b59 to c597ad3 Compare December 30, 2024 12:40
@mchudy
Copy link
Contributor Author

mchudy commented Dec 30, 2024

I'm not sure why the CI build fails. Locally it builds successfully. Do you have any tip maybe what can be the cause of this issue?

Failed to build iOS app
Lexical or Preprocessor Issue (Xcode): 'FLTCaptureDeviceControlling.h' file not found
/Volumes/Work/s/w/ir/x/w/packages/packages/camera/camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/include/camera_avfoundation/FLTCamMediaSettingsAVWrapper.h:7:8

@hellohuanlin
Copy link
Contributor

I'm not sure why the CI build fails. Locally it builds successfully. Do you have any tip maybe what can be the cause of this issue?

Failed to build iOS app
Lexical or Preprocessor Issue (Xcode): 'FLTCaptureDeviceControlling.h' file not found
/Volumes/Work/s/w/ir/x/w/packages/packages/camera/camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/include/camera_avfoundation/FLTCamMediaSettingsAVWrapper.h:7:8

it's been a while since i touched this, but it sounds like either module map or umbrella header. I'd look into a similar header and see how it is setup.

@hellohuanlin
Copy link
Contributor

I don't find a 2nd reviewer from the CODEOWNER for this plugin. Maybe @LouiseHsu who recently did a similar swift migration?

@mchudy mchudy force-pushed the feature/camera-ocmock-refactoring-part2 branch from 840af1d to 8256579 Compare December 30, 2024 22:47
@hellohuanlin hellohuanlin requested a review from jmagman December 30, 2024 23:20
@mchudy mchudy force-pushed the feature/camera-ocmock-refactoring-part2 branch 3 times, most recently from b1204d5 to 07138dc Compare December 31, 2024 10:55
@mchudy mchudy force-pushed the feature/camera-ocmock-refactoring-part2 branch from 07138dc to cdb1578 Compare December 31, 2024 11:15
@mchudy mchudy force-pushed the feature/camera-ocmock-refactoring-part2 branch 2 times, most recently from f7a4f92 to 3628b1f Compare January 1, 2025 11:05
@mchudy mchudy force-pushed the feature/camera-ocmock-refactoring-part2 branch from 3628b1f to 2a070ca Compare January 2, 2025 08:50
@mchudy mchudy force-pushed the feature/camera-ocmock-refactoring-part2 branch from d65a805 to 04f1e8b Compare January 2, 2025 09:12
@mchudy
Copy link
Contributor Author

mchudy commented Jan 2, 2025

I fixed the CI, kind of a workaround (for some reason I cannot get this to work with subfolders). I'm gonna try to fix that in further PRs, but I don't want to block this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants