Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rfw] Activate leak testing #8370

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ValentinVignal
Copy link
Contributor

The package manipulates disposable objects. This PR activates leak testing to make sure disposable objects are correctly disposed.

It also fixes the memory leak warnings from the tests

See the documentation: https://github.com/dart-lang/leak_tracker/blob/main/doc%2Fleak_tracking%2FDETECT.md

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ValentinVignal ValentinVignal requested a review from Hixie as a code owner January 5, 2025 14:08
@ValentinVignal
Copy link
Contributor Author

Since I modified only the tests, I think this PR is eligible for the tags override: no versioning needed and override: no changelog needed

@github-actions github-actions bot added the p: rfw Remote Flutter Widgets label Jan 5, 2025
@ValentinVignal
Copy link
Contributor Author

cc @polina-c

@polina-c polina-c added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: rfw Remote Flutter Widgets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants