[two_dimensional_scrollables] prepare for const AnimationStyle
#8397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-thegrate
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 15, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 15, 2025
flutter/packages@d1fd623...f73cb00 2025-01-14 [email protected] Roll Flutter from 72db8f6 to 40c2b86 (33 revisions) (flutter/packages#8428) 2025-01-14 [email protected] [two_dimensional_scrollables] prepare for `const AnimationStyle` (flutter/packages#8397) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ahmedrasar
pushed a commit
to ahmedrasar/flutter
that referenced
this pull request
Jan 16, 2025
…r#161672) flutter/packages@d1fd623...f73cb00 2025-01-14 [email protected] Roll Flutter from 72db8f6 to 40c2b86 (33 revisions) (flutter/packages#8428) 2025-01-14 [email protected] [two_dimensional_scrollables] prepare for `const AnimationStyle` (flutter/packages#8397) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Fix DropDownMenu initialSelection not reflecting label change Fixes DropDownMenu.didUpdateWidget() overlooking label change if oldWidget had the same initialSelection. Fixes Localization not having effect on DropDownMenu initialSelection.
ahmedrasar
pushed a commit
to ahmedrasar/flutter
that referenced
this pull request
Jan 16, 2025
…r#161672) flutter/packages@d1fd623...f73cb00 2025-01-14 [email protected] Roll Flutter from 72db8f6 to 40c2b86 (33 revisions) (flutter/packages#8428) 2025-01-14 [email protected] [two_dimensional_scrollables] prepare for `const AnimationStyle` (flutter/packages#8397) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Fix DropDownMenu initialSelection not reflecting label change Fixes DropDownMenu.didUpdateWidget() overlooking label change if oldWidget had the same initialSelection. Fixes Localization not having effect on DropDownMenu initialSelection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unblocks flutter/flutter#160564
Will go back through and implement
constconstructors in these spots once the framework PR lands.