[google_sign_in_android] Corrects typo in logs (#6216)

flutter · Sep 14, 2022 · 64a2931 · 64a2931
1 parent 993170f
commit 64a2931
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 12 deletions.
diff --git a/packages/google_sign_in/google_sign_in_android/CHANGELOG.md b/packages/google_sign_in/google_sign_in_android/CHANGELOG.md
@@ -1,5 +1,6 @@
-## NEXT
+## 6.1.1
 
+* Corrects typos in plugin error logs and removes not actionable warnings.
 * Updates minimum Flutter version to 2.10.
 
 ## 6.1.0

diff --git a/..._in_android/android/src/main/java/io/flutter/plugins/googlesignin/GoogleSignInPlugin.java b/..._in_android/android/src/main/java/io/flutter/plugins/googlesignin/GoogleSignInPlugin.java
@@ -356,16 +356,12 @@ public void init(
         // Android apps are identified by their package name and the SHA-1 of their signing key.
         // https://developers.google.com/android/guides/client-auth
         // https://developers.google.com/identity/sign-in/android/start#configure-a-google-api-project
-        if (!Strings.isNullOrEmpty(clientId)) {
-          if (Strings.isNullOrEmpty(serverClientId)) {
-            Log.w(
-                "google_sing_in",
-                "clientId is not supported on Android and is interpreted as serverClientId."
-                    + "Use serverClientId instead to suppress this warning.");
-            serverClientId = clientId;
-          } else {
-            Log.w("google_sing_in", "clientId is not supported on Android and is ignored.");
-          }
+        if (!Strings.isNullOrEmpty(clientId) && Strings.isNullOrEmpty(serverClientId)) {
+          Log.w(
+              "google_sign_in",
+              "clientId is not supported on Android and is interpreted as serverClientId. "
+                  + "Use serverClientId instead to suppress this warning.");
+          serverClientId = clientId;
         }
 
         if (Strings.isNullOrEmpty(serverClientId)) {

diff --git a/packages/google_sign_in/google_sign_in_android/pubspec.yaml b/packages/google_sign_in/google_sign_in_android/pubspec.yaml
@@ -2,7 +2,7 @@ name: google_sign_in_android
 description: Android implementation of the google_sign_in plugin.
 repository: https://github.com/flutter/plugins/tree/main/packages/google_sign_in/google_sign_in_android
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+google_sign_in%22
-version: 6.1.0
+version: 6.1.1
 
 environment:
   sdk: ">=2.14.0 <3.0.0"