Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Commit

Permalink
[video_player] Add URL for exoplayer to maven for all dependents (#3979)
Browse files Browse the repository at this point in the history
JCenter has the older version of ExoPlayer that the plugin currently uses, but Google's maven server doesn't so we need to add a workaround in the short term for the removal of JCenter in #3924 to avoid breaking clients of video_player.

This was not caught in presubmit because the video_player example had this same workaround left over from an issue several years ago that caused JCenter not to have that version either; that issue was since fixed, but the workaround was never removed. This removes the example-level workaround so the example won't mask exoplayer maven issues in the future.

(Also temporarily re-adds the workaround to the camera example, which broke post-publishing, to fix the tree. All example workarounds should be removable once this change is published.)
  • Loading branch information
stuartmorgan authored May 26, 2021
1 parent 2576d6b commit 8f4c774
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 4 deletions.
3 changes: 3 additions & 0 deletions packages/camera/camera/example/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ allprojects {
repositories {
google()
mavenCentral()
maven {
url 'https://google.bintray.com/exoplayer/'
}
}
}

Expand Down
5 changes: 5 additions & 0 deletions packages/video_player/video_player/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 2.1.4

* Add an exoplayer URL to the maven repositories to address
a possible build regression in 2.1.2.

## 2.1.3

* Fix pointer value to boolean conversion analyzer warnings.
Expand Down
6 changes: 6 additions & 0 deletions packages/video_player/video_player/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ rootProject.allprojects {
repositories {
google()
mavenCentral()
// Gradle versions older than 2.13.3 aren't published to the servers
// above, so add this URL as a workaround until upgrading past that
// version.
maven {
url 'https://google.bintray.com/exoplayer/'
}
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ allprojects {
repositories {
google()
mavenCentral()
maven {
url 'https://google.bintray.com/exoplayer/'
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion packages/video_player/video_player/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Flutter plugin for displaying inline video with other Flutter
widgets on Android, iOS, and web.
repository: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+video_player%22
version: 2.1.3
version: 2.1.4

environment:
sdk: ">=2.12.0 <3.0.0"
Expand Down

0 comments on commit 8f4c774

Please sign in to comment.