[image_picker_windows] Use const instead of final for XTypeGroup. (#6544

)
flutter · Oct 6, 2022 · d4db207 · d4db207
1 parent 3cd4360
commit d4db207
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 12 deletions.
diff --git a/packages/image_picker/image_picker_windows/CHANGELOG.md b/packages/image_picker/image_picker_windows/CHANGELOG.md
@@ -1,5 +1,6 @@
-## NEXT
+## 0.1.0+3
 
+* Changes XTypeGroup initialization from final to const.
 * Updates minimum Flutter version to 2.10.
 
 ## 0.1.0+2

diff --git a/packages/image_picker/image_picker_windows/lib/image_picker_windows.dart b/packages/image_picker/image_picker_windows/lib/image_picker_windows.dart
@@ -118,9 +118,7 @@ class ImagePickerWindows extends ImagePickerPlatform {
       throw UnimplementedError(
           'ImageSource.gallery is currently the only supported source on Windows');
     }
-    final XTypeGroup typeGroup =
-        // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
-        // ignore: prefer_const_constructors
+    const XTypeGroup typeGroup =
         XTypeGroup(label: 'images', extensions: imageFormats);
     final XFile? file = await fileSelector
         .openFile(acceptedTypeGroups: <XTypeGroup>[typeGroup]);
@@ -144,9 +142,7 @@ class ImagePickerWindows extends ImagePickerPlatform {
       throw UnimplementedError(
           'ImageSource.gallery is currently the only supported source on Windows');
     }
-    final XTypeGroup typeGroup =
-        // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
-        // ignore: prefer_const_constructors
+    const XTypeGroup typeGroup =
         XTypeGroup(label: 'videos', extensions: videoFormats);
     final XFile? file = await fileSelector
         .openFile(acceptedTypeGroups: <XTypeGroup>[typeGroup]);
@@ -162,9 +158,7 @@ class ImagePickerWindows extends ImagePickerPlatform {
     double? maxHeight,
     int? imageQuality,
   }) async {
-    final XTypeGroup typeGroup =
-        // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
-        // ignore: prefer_const_constructors
+    const XTypeGroup typeGroup =
         XTypeGroup(label: 'images', extensions: imageFormats);
     final List<XFile> files = await fileSelector
         .openFiles(acceptedTypeGroups: <XTypeGroup>[typeGroup]);

diff --git a/packages/image_picker/image_picker_windows/pubspec.yaml b/packages/image_picker/image_picker_windows/pubspec.yaml
@@ -2,7 +2,7 @@ name: image_picker_windows
 description: Windows platform implementation of image_picker
 repository: https://github.com/flutter/plugins/tree/main/packages/image_picker/image_picker_windows
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+image_picker%22
-version: 0.1.0+2
+version: 0.1.0+3
 
 environment:
   sdk: ">=2.12.0 <3.0.0"
@@ -16,7 +16,7 @@ flutter:
         dartPluginClass: ImagePickerWindows
 
 dependencies:
-  file_selector_platform_interface: ^2.0.4
+  file_selector_platform_interface: ^2.2.0
   file_selector_windows: ^0.8.2
   flutter:
     sdk: flutter