Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[path_provider] Add iOS unit tests #3998

Merged
merged 2 commits into from
Jun 2, 2021
Merged

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Jun 2, 2021

Add RunnerTests XCTest iOS target to example app that creates the plugin and asserts it's not nil, proving linking is set up correctly.

path_provider part of flutter/flutter#83357

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no native UI in path_provider, so there's no actual value I can imagine from having native UI tests for it. The goal is to have the scaffolding in place for every test we might actually want to add, but adding scaffolding that we won't ever use will just mean maintenance overhead and longer bot cycles.

@jmagman jmagman changed the title [path_provider] Add iOS unit and UI tests [path_provider] Add iOS unit tests Jun 2, 2021
@jmagman
Copy link
Member Author

jmagman commented Jun 2, 2021

There's no native UI in path_provider, so there's no actual value I can imagine from having native UI tests for it. The goal is to have the scaffolding in place for every test we might actually want to add, but adding scaffolding that we won't ever use will just mean maintenance overhead and longer bot cycles.

Removed the target.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuartmorgan stuartmorgan added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jun 2, 2021
@fluttergithubbot fluttergithubbot merged commit 4ec1169 into flutter:master Jun 2, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 2, 2021
@jmagman jmagman deleted the pp-test branch June 2, 2021 19:27
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Jun 2, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes p: path_provider platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants