-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no native UI in path_provider
, so there's no actual value I can imagine from having native UI tests for it. The goal is to have the scaffolding in place for every test we might actually want to add, but adding scaffolding that we won't ever use will just mean maintenance overhead and longer bot cycles.
Removed the target. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Add
RunnerTests
XCTest iOS target to example app that creates the plugin and asserts it's not nil, proving linking is set up correctly.path_provider part of flutter/flutter#83357
Pre-launch Checklist
dart format
. See plugin_tool format)[shared_preferences]
///
).