-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[shared_preferences] Fix example in readme for mocking values #4411
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! A few small things inline:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! @bparrishMines for second review.
@bparrishMines Ping on this trivial review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small nit and it looks like the CHANGELOG
needs one more update.
Co-authored-by: Maurice Parrish <[email protected]>
@bparrishMines It's been updated; PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request is not suitable for automatic merging in its current state.
|
@ueman Could you update this for the version conflict so we can land it? (I'm not sure why the GitHub UI is showing this as not having conflicts, it definitely does.) |
Nevermind, the GitHub UI issue resolved itself, so I was able to resolve the conflicts directly. |
This pull request is not suitable for automatic merging in its current state.
|
This needs master merged in to pick up the fix for the |
…r#4411) This fixes the example for mocking values in the readme of shared_preferences. After the NNBD migration mock values can only be of type Object.
…r#4411) This fixes the example for mocking values in the readme of shared_preferences. After the NNBD migration mock values can only be of type Object.
This fixes the example for mocking values in the readme of shared_preferences.
After the NNBD migration mock values can only be of type
Object
.There are no issues for this small readme error.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format
.)[shared_preferences]
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.