Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Remove -Werror from deprecated plugin Android builds #4466

Merged
merged 2 commits into from
Nov 1, 2021
Merged

Remove -Werror from deprecated plugin Android builds #4466

merged 2 commits into from
Nov 1, 2021

Conversation

stuartmorgan
Copy link
Contributor

Now that the default Flutter app template uses a newer compile SDK on Android, the build_all test (which generates an application) is subject to new out-of-band deprecation warnings. For plugins with -Werror specified, these are errors, which break CI.

To prevent this, remove -Werror from the Android builds of all the deprecated plugins that used it.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@stuartmorgan stuartmorgan requested a review from blasten November 1, 2021 20:11
@google-cla google-cla bot added the cla: yes label Nov 1, 2021
@stuartmorgan stuartmorgan merged commit 16e410b into flutter:master Nov 1, 2021
@stuartmorgan stuartmorgan deleted the android-deprecated-werror branch November 1, 2021 20:36
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2021
@engine-flutter-autoroll
16e410b Remove -Werror from deprecated plugin Android builds (flutter…
d53f3e4 
…/plugins#4466)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2021
@engine-flutter-autoroll
16e410b Remove -Werror from deprecated plugin Android builds (flutter…
cb75673 
…/plugins#4466)
NickalasB added a commit to NickalasB/plugins that referenced this pull request Nov 4, 2021
@NickalasB
Merge branch 'master' into add_zoom_to_android_webview
e17df4c 
* master:
  [webview_flutter] Deprecate evaluateJavascript in favour of runJavaScript and runJavaScriptForResult. (flutter#4403)
  [webview_flutter] Add interface methods to load local files and HTML strings. (flutter#4446)
  [ci] add pedantic dep to new in_app_purchase pkgs (flutter#4471)
  [ci] Remove unused dep from file_selector. (flutter#4468)
  [ci] update build_runner dep in android_intent and file_selector example (flutter#4467)
  [webview_flutter] Add platform interface method `loadRequest`. (flutter#4450)
  Remove -Werror from deprecated plugin Android builds (flutter#4466)
  [webview_flutter] Update webview packages for Android and iOS to implement `runJavascript` and `runJavascriptReturningResult`. (flutter#4402)
  [camera] Fix CamcorderProfile Usages (flutter#4423)
  [google_sign_in] Use a transparent image as a placeholder for the `GoogleUserCircleAvatar` (flutter#4391)
  [in_app_purchase]IAP/platform interface add cancel status (flutter#4093)
  [image_picker] doc:readme image picker misprints (flutter#4421)
  Support Hybrid Composition through the GoogleMaps Widget (flutter#4082)
  [path_provider] started supporting background platform channels (flutter#4443)
  [device_info] started using Background Platform Channels (flutter#4456)

# Conflicts:
#	packages/webview_flutter/webview_flutter/CHANGELOG.md
#	packages/webview_flutter/webview_flutter/pubspec.yaml
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
@stuartmorgan @amantoux
Remove -Werror from deprecated plugin Android builds (flutter#4466)
79605b3 
Now that the default Flutter app template uses a newer compile SDK on Android, the build_all test (which generates an application) is subject to new out-of-band deprecation warnings. For plugins with `-Werror` specified, these are errors, which break CI.

To prevent this, remove `-Werror` from the Android builds of all the deprecated plugins that used it.
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@stuartmorgan @KyleFin
Remove -Werror from deprecated plugin Android builds (flutter#4466)
6b6c38f 
Now that the default Flutter app template uses a newer compile SDK on Android, the build_all test (which generates an application) is subject to new out-of-band deprecation warnings. For plugins with `-Werror` specified, these are errors, which break CI.

To prevent this, remove `-Werror` from the Android builds of all the deprecated plugins that used it.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blasten blasten blasten approved these changes

Assignees
No one assigned
Labels
cla: yes p: android_alarm_manager p: android_intent p: connectivity platform-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuartmorgan @blasten