Camera plugin first working version (IOS and Android).

[quentinleguennec]

Ready for review.

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

[nisdis]

@googlebot I've signed the Google Corporate CLA agreement on [email protected]

[rodydavis]

Will there be a native UI version too?
Just like how image_picker uses the stock image picker and camera. That way the camera and photo album UI is always up to date with the SDK or iOS version the app is running on.

[rodydavis]

When I run the example on a Google Pixel everything is normal. On an iPhone 6s the first video you take is not in the preview window in the bottom and the second video is. Then every other video you take shows up in the preview window otherwise it shows white after recording.

[sigurdm]

@AppleEducate What do you mean by native UI version?
This plugin just provides access to the camera preview in a texture rectangle, and to recording movies and still pictures

[rodydavis]

@sigurdm Native UI as in the stock camera apps on Android and iOS. That would be the full screen camera app that takes care of the flash, camera modes and selecting the camera for you. This plugin is great In Giving you access to the raw camera but it would be nice to also provide a way to ask the user for a photo or video and they can choose on from the Library or take a new one like the image picker does. It navigates to the Stock Camera application on the phone and navigates back with the file.

[sigurdm]

@AppleEducate I think that's outside the responsibilities of this plugin.
I think the behaviour you want can be obtained by combining this plugin with image_picker?

Otherwise please file a new issue at https://github.com/flutter/flutter/issues/new to have track of the discussion in the right place.

[rodydavis]

@sigurdm I think you're right. This may be something for a media_picker plugin.

[quentinleguennec]

@sigurdm @AppleEducate I've been looking into the bug with the IOS version, I tracked it down to an issue in the video player plugin. More specifically, an invokeMethod call to "dispose" is not always returning, so the preview is not playing. I'll try to fix it and submit a PR on the video player. Since this is not a bug with the camera plugin we can push the PR forward.
@sigurdm did you find anything else to fix?

[quentinleguennec]

I created a new PR with a fix for the issue: PR #557
I couldn't reproduce the issue with this fix.

[rodydavis]

@sigurdm I was able to create the plugin I was describing. Capture and Select both Photos and Videos from the Gallery and with the camera using the stock camera apps. I took the image_picker plugin and added video capability. What should I do now? Should I create a video_picker plugin and media_picker plugin that have a dependency on image_picker and video_picker or just bring all the code into media_picker?

https://github.com/AppleEducate/media_picker

[quentinleguennec]

Hi @sigurdm !
Do you have any more improvements we could add to the plugin? Also, for PR #557, do you know someone I could add as reviewer?

[rodydavis]

@sigurdm I created a Pull Request for updating image_picker to add video capability:
#565

[tecbot]

as @sigurdm mentioned in his PR, the aspect ratio is wired in iOS, specially if running in fullscreen and on a iPhone X. Looks like the aspect ratio of the video controller is not correctly calculated.

[sigurdm]

This needs to be 0.5.2

[sigurdm]

Besides the need to use video_player 0.5.2 in the example pubspec which includes the fix, this LGTM
You can add yourself to the AUTHORs file if you want.

[quentinleguennec]

@sigurdm Awesome! I updated the pubspec and the authors. Thank you for your review :)

[sigurdm]

Thanks for all the hard work!

[norbertkross]

how do I use the camera plugin to record video

[quentinleguennec]

Hi Norbert. There is a big example of the plugin with video recording in the example folder: https://github.com/flutter/plugins/blob/master/packages/camera/example/lib/main.dart 2018-08-13 20:10 GMT+01:00 Norbert Aberor <[email protected]>:

…

how do I use the camera plugin to record video — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#458 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APGcdWOZ8WLOgjhZH4P-YS7QVf-hthBbks5uQc8hgaJpZM4TE46p> .

[Niroop4444]

Can i get to know how to mute the mic while recording?

[crankyvein]

Can you please add some more functionality
in camera plugin like changing frame rate adding filters, because others app cameras are more advanced like snapchat and Instagram but in camera plugin. We only have basic functionality like capturing image and recording videos that's it.
Please please please please please add these functionality as soon as possible because we need them.