Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Multiple app support for cloud_firestore #476

Merged

Conversation

collinjackson
Copy link
Contributor

@collinjackson collinjackson commented Apr 9, 2018

In order to pass DocumentReference across the Firestore codec, we need to be able to serialize a Firebase app. We now guarantee that the app of a Firestore is never null.

Requires #478

@collinjackson collinjackson changed the title Multiple app support for cloud_firestore, including tweaks to firebase_core Multiple app support for cloud_firestore Apr 9, 2018
@collinjackson collinjackson requested a review from kroikie April 9, 2018 12:26
Copy link
Contributor

@mravn-google mravn-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

final String appName =
utf8.decoder.convert(buffer.getUint8List(appNameLength));
final FirebaseApp app = new FirebaseApp(name: appName);
final Firestore firestore = new Firestore(app: app);
final int length = readSize(buffer);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pathLength

@collinjackson collinjackson merged commit 7e4d7a6 into flutter:master Apr 10, 2018
slightfoot pushed a commit to slightfoot/plugins that referenced this pull request Jun 5, 2018
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants