This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Multiple app support for cloud_firestore #476
Merged
collinjackson
merged 11 commits into
flutter:master
from
collinjackson:firestore_multiple_app_support
Apr 10, 2018
Merged
Multiple app support for cloud_firestore #476
collinjackson
merged 11 commits into
flutter:master
from
collinjackson:firestore_multiple_app_support
Apr 10, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6a8d47a
to
805cb06
Compare
mravn-google
approved these changes
Apr 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
final String appName = | ||
utf8.decoder.convert(buffer.getUint8List(appNameLength)); | ||
final FirebaseApp app = new FirebaseApp(name: appName); | ||
final Firestore firestore = new Firestore(app: app); | ||
final int length = readSize(buffer); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pathLength
slightfoot
pushed a commit
to slightfoot/plugins
that referenced
this pull request
Jun 5, 2018
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to pass
DocumentReference
across the Firestore codec, we need to be able to serialize a Firebase app. We now guarantee that theapp
of aFirestore
is never null.Requires #478