This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Support StorageReference#writeToFile #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szakarias
force-pushed
the
storageReferenceWriteToFile
branch
5 times, most recently
from
605efe4 to
0335232
Compare
szakarias
force-pushed
the
storageReferenceWriteToFile
branch
from
0335232 to
74e8d34
Compare
mravn-google
approved these changes
Apr 30, 2018
| await tempFile.create(); | ||
| assert(await tempFile.readAsString() == ""); | ||
| final StorageFileDownloadTask task = ref.writeToFile(tempFile); | ||
| final int bytes = (await task.future).totalByteCount; |
There was a problem hiding this comment.
[nit] Maybe rename to byteCount so we don't confuse it with the actual bytes downloaded.
haydenflinner
pushed a commit
to haydenflinner/plugins
that referenced
this pull request
May 4, 2018
slightfoot
pushed a commit
to slightfoot/plugins
that referenced
this pull request
Jun 5, 2018
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.