This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[tools] Add
update-release-info
#5643[tools] Add
update-release-info
#5643Changes from 1 commit
cde14d8
1e6e3e3
0d42f3f
c820112
8bbf789
62debc4
f7d69f3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can
--run-on-changed-packages
be the default behavior for this tool, so people don't have to "remember" to pass it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would require some re-plumbing to allow a command to change the default package selection behavior, and it would make it inconsistent with all the other commands. But then, it's a different kind of command than most of the others.
I'll play around with that tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I came up with a different solution when I woke up this morning :) Instead of making this command have non-standard package targeting, I just made
minimal
skip any package that has no changes at all. That makes it even easier to use, since you don't have to worry about the base treeish thatrun-on-changed-packages
is using.You'll still need to explicitly target for the other modes, but I don't expect the other modes to actually be useful in a bulk-update setting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't you place a markdown file in example alternatively?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True; added support for README.md and example.md.
(The heuristic here isn't perfect; there are some even more obscure files that could be shown but we never use, and this could also have false positives if, e.g., you change one of the potentially special files in a package that also has one of the other, higher-priority files, but in practice that's going to be extremely rare, and there's always a way to override the heuristic.)