Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Bump camera_web and camera_android versions to update permission exception codes #6081

Merged
merged 5 commits into from
Jul 13, 2022
Merged

[camera] Bump camera_web and camera_android versions to update permission exception codes #6081

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5ea6444
Make breaking change for camera package
camsim99 Jul 7, 2022
5d9034c
Edit changelog
camsim99 Jul 8, 2022
48d0575
Merge remote-tracking branch 'upstream/main' into issue_101384_3
camsim99 Jul 11, 2022
516879b
Merge remote-tracking branch 'upstream/main' into issue_101384_3
camsim99 Jul 11, 2022
ce5fce2
Merge remote-tracking branch 'upstream/main' into issue_101384_3
camsim99 Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/camera/camera/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## NEXT
## 0.10.0

* **Breaking Change** Bumps default camera_web package version to 0.3.0 and camaera_android package version to 0.10.0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional nit: I wouldn't mention the implementation package versions since that's largely an implementation detail of federation; I would just say the part about the exception code changes since that's the actual breaking change.

which updates permission exception code from `cameraPermission` to `CameraAccessDenied` and `AudioAccessDenied`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AudioAccessDenied is not available for camera_web tho. Can you separate camera_web and camera_android updates into 2 lines?

* Ignores unnecessary import warnings in preparation for [upcoming Flutter changes](https://github.com/flutter/flutter/pull/106316).

## 0.9.8+1
Expand Down
2 changes: 0 additions & 2 deletions packages/camera/camera/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,6 @@ Here is a list of all permission error codes that can be thrown:

- `AudioAccessRestricted`: iOS only for now. Thrown when audio access is restricted and users cannot grant permission (parental control).

- `cameraPermission`: Android and Web only. A legacy error code for all kinds of camera permission errors.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

### Example

Here is a small example flutter app displaying a full screen camera preview.
Expand Down
4 changes: 0 additions & 4 deletions packages/camera/camera/example/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,10 +716,6 @@ class _CameraExampleHomeState extends State<CameraExampleHome>
// iOS only
showInSnackBar('Audio access is restricted.');
break;
case 'cameraPermission':
// Android & web only
showInSnackBar('Unknown permission error.');
break;
default:
_showCameraException(e);
break;
Expand Down
6 changes: 3 additions & 3 deletions packages/camera/camera/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: A Flutter plugin for controlling the camera. Supports previewing
Dart.
repository: https://github.com/flutter/plugins/tree/main/packages/camera/camera
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22
version: 0.9.8+1
version: 0.10.0

environment:
sdk: ">=2.14.0 <3.0.0"
Expand All @@ -21,10 +21,10 @@ flutter:
default_package: camera_web

dependencies:
camera_android: ^0.9.7+1
camera_android: ^0.10.0
camera_avfoundation: ^0.9.7+1
camera_platform_interface: ^2.2.0
camera_web: ^0.2.1
camera_web: ^0.3.0
flutter:
sdk: flutter
flutter_plugin_android_lifecycle: ^2.0.2
Expand Down