[google_sign_in] Add forceCodeForRefreshToken parameter platform implementations #6130
Conversation
…ementations for forceCodeForRefreshToken
…ssary changes to google_sign_in_web
|
It looks like several of the new unit tests are failing; see https://cirrus-ci.com/task/5986776966758400 for details. |
…tests, remove unnecessary overrides
|
@stuartmorgan My bad – for whatever reason, Android Studio was loading the tests from the pub version of the plugin instead of the local branch...those are fixed now, and should be using the same style as the other init tests that were added. |
| @@ -1,3 +1,7 @@ | |||
| ## 6.0.2 | |||
There was a problem hiding this comment.
Nit: since you are adding a feature these should be minor version bumps rather than bugfix version bumps.
| @@ -101,16 +101,18 @@ void main() { | |||
| test('Other functions pass through arguments to the channel', () async { | |||
| final Map<Function, Matcher> tests = <Function, Matcher>{ | |||
| () { | |||
| googleSignIn.init( | |||
There was a problem hiding this comment.
Here and on iOS, please add a new test instead of changing the old one, so that we have coverage that init hasn't regressed (and doesn't later).
…rsion instead of bugfix; add new tests instead of modifying existing init tests
There was a problem hiding this comment.
LGTM! I'm assuming that @camsim99 has no other comments since the main PR was approved.
stuartmorgan
added
the
autosubmit
…tform implementations (flutter/plugins#6130)
…tform implementations (flutter/plugins#6130)
This is the platform implementation companion to #3356.
Related Issues
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.