Fixed bug in handleStopListeningAuthState method

[Noble-Mushtak]

The following refers to variables used in FirebaseAuthPlugin.java. Basically, authStateListeners.removeAt(id) was changed to authStateListeners.remove(id).

Here, id is a key corresponding to listener in the SparseArray. Since id is a key, not an index, remove() should be used instead of removeAt(). Otherwise, out-of-bounds exceptions may occur, such as the following error that occurred after a subscription was canceled to onAuthStateChanged in a Flutter app I am working on:

E/MethodChannel#plugins.flutter.io/firebase_auth( 2008): Failed to handle method call
E/MethodChannel#plugins.flutter.io/firebase_auth( 2008): java.lang.ArrayIndexOutOfBoundsException: length=13; index=13
E/MethodChannel#plugins.flutter.io/firebase_auth( 2008): 	at android.util.SparseArray.removeAt(SparseArray.java:147)
E/MethodChannel#plugins.flutter.io/firebase_auth( 2008): 	at io.flutter.plugins.firebaseauth.FirebaseAuthPlugin.handleStopListeningAuthState(FirebaseAuthPlugin.java:351)
E/MethodChannel#plugins.flutter.io/firebase_auth( 2008): 	at io.flutter.plugins.firebaseauth.FirebaseAuthPlugin.onMethodCall(FirebaseAuthPlugin.java:111)
E/MethodChannel#plugins.flutter.io/firebase_auth( 2008): 	at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler.onMessage(MethodChannel.java:191)
E/MethodChannel#plugins.flutter.io/firebase_auth( 2008): 	at io.flutter.view.FlutterNativeView.handlePlatformMessage(FlutterNativeView.java:136)
E/MethodChannel#plugins.flutter.io/firebase_auth( 2008): 	at android.os.MessageQueue.nativePollOnce(Native Method)
E/MethodChannel#plugins.flutter.io/firebase_auth( 2008): 	at android.os.MessageQueue.next(MessageQueue.java:143)
E/MethodChannel#plugins.flutter.io/firebase_auth( 2008): 	at android.os.Looper.loop(Looper.java:122)
E/MethodChannel#plugins.flutter.io/firebase_auth( 2008): 	at android.app.ActivityThread.main(ActivityThread.java:5254)
E/MethodChannel#plugins.flutter.io/firebase_auth( 2008): 	at java.lang.reflect.Method.invoke(Native Method)
E/MethodChannel#plugins.flutter.io/firebase_auth( 2008): 	at java.lang.reflect.Method.invoke(Method.java:372)
E/MethodChannel#plugins.flutter.io/firebase_auth( 2008): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
E/MethodChannel#plugins.flutter.io/firebase_auth( 2008): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)

[mravn-google]

Thanks for the fix. Please bump the version in pubspec.yaml and add a CHANGELOG.md entry.

[Hixie]

cc @kroikie for review

[mravn-google]

LGTM

[mravn-google]

New version published.