Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_sign_in_android] Corrects typo in logs #6216

Merged
merged 7 commits into from
Sep 14, 2022
Merged

[google_sign_in_android] Corrects typo in logs #6216

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
da81ebd
Corrects typo in logs
Milvintsiss Aug 8, 2022
1baa588
Improves changelog version change message
Milvintsiss Aug 9, 2022
86d15de
Bumps package version
Milvintsiss Aug 9, 2022
309d535
Removes not actionable warnings
Milvintsiss Aug 10, 2022
95137ee
Removes the extra parenthesis
Milvintsiss Aug 11, 2022
b51b5a7
Corrects file not using Google Java Format conventions
Milvintsiss Aug 11, 2022
3a8972d
Merge branch 'main' into google_sign_in_typo
Milvintsiss Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/google_sign_in/google_sign_in_android/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 6.0.2

* Corrects typos in plugin error logs and removes not actionable warnings.

## 6.0.1

* Updates gradle version to 7.2.1 on Android.
Expand Down
16 changes: 6 additions & 10 deletions ..._in_android/android/src/main/java/io/flutter/plugins/googlesignin/GoogleSignInPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,16 +347,12 @@ public void init(
// Android apps are identified by their package name and the SHA-1 of their signing key.
// https://developers.google.com/android/guides/client-auth
// https://developers.google.com/identity/sign-in/android/start#configure-a-google-api-project
if (!Strings.isNullOrEmpty(clientId)) {
if (Strings.isNullOrEmpty(serverClientId)) {
Log.w(
"google_sing_in",
"clientId is not supported on Android and is interpreted as serverClientId."
+ "Use serverClientId instead to suppress this warning.");
serverClientId = clientId;
} else {
Log.w("google_sing_in", "clientId is not supported on Android and is ignored.");
}
if (!Strings.isNullOrEmpty(clientId) && Strings.isNullOrEmpty(serverClientId)) {
Log.w(
"google_sign_in",
"clientId is not supported on Android and is interpreted as serverClientId. "
+ "Use serverClientId instead to suppress this warning.");
serverClientId = clientId;
}

if (Strings.isNullOrEmpty(serverClientId)) {
Expand Down
2 changes: 1 addition & 1 deletion packages/google_sign_in/google_sign_in_android/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: google_sign_in_android
description: Android implementation of the google_sign_in plugin.
repository: https://github.com/flutter/plugins/tree/main/packages/google_sign_in/google_sign_in_android
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+google_sign_in%22
version: 6.0.1
version: 6.0.2

environment:
sdk: ">=2.14.0 <3.0.0"
Expand Down