-
Notifications
You must be signed in to change notification settings - Fork 9.8k
video_player: frame accurate seekTo on iOS #622
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
@googlebot I signed it! |
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. Please add pubspec.yaml version bump and CHANGELOG.md entry.
@mravn-google done ;) |
This branch seems to need a rebase now. Sorry. |
Same behaviour as on android. A keyframe accurate seekTo method could be introduced for both platforms to enhance performance at the cost of accuracy.
No worries. Branch has been rebased. |
Do you prefer the commits to be squashed when we are at it? |
Thanks. I'll squash them as I merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Same behaviour as on android. A keyframe accurate seekTo method could be introduced for both platforms to enhance performance at the cost of accuracy.