This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Setup ios text detector #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mravn-google
approved these changes
Jun 22, 2018
| - (NSMutableArray *)getElementData:(NSArray<FIRVisionTextElement *> *)elements { | ||
| NSMutableArray *elementDataArray = [NSMutableArray array]; | ||
| [elements enumerateObjectsUsingBlock:^(FIRVisionTextElement *_Nonnull element, NSUInteger idx, | ||
| BOOL *_Nonnull stop) { |
| NSMutableArray *lineDataArray = [NSMutableArray array]; | ||
|
|
||
| [lines enumerateObjectsUsingBlock:^(FIRVisionTextLine *_Nonnull line, NSUInteger idx, | ||
| BOOL *_Nonnull stop) { |
| text:(NSString *)text { | ||
| __block NSMutableArray<NSArray *> *points = [NSMutableArray array]; | ||
| [cornerPoints enumerateObjectsUsingBlock:^(NSValue *_Nonnull point, NSUInteger idx, | ||
| BOOL *_Nonnull stop) { |
There was a problem hiding this comment.
Since you are not using the idx, it may be simpler with just a for loop:
for (NSValue* point in cornerPoints) {
...
}| cornerPoints:block.cornerPoints | ||
| text:block.text]]; | ||
| blockData[@"lines"] = [self getLineData:block.lines]; | ||
| } else if ([feature isKindOfClass:[FIRVisionTextBlock class]]) { |
There was a problem hiding this comment.
You probably meant [FIRVisionTextLine class] here.
|
@bparrishMines There are a lot of commits here mentioning Dart and Android, yet this PR contains only iOS changes. Are you missing a rebase or some such? |
|
@mravn-google This branch was branched off the android side PR. I think that is where all the extra commits are from |
|
Actually, I just understood what you meant about missing the rebase. |
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
* Initial 'fluter create' for Firebase ML Vision plugin * Formatting * More Formatting * Import ordering * Added android app to firebase * Added ios app to firebase * Added ml vision to android and ios * WIP dart side of ml vision * finish dart side of ml vision and text detector * Added TextDetector tests * Added some comments * Finished comments * Removed usused dependency * Formatting and unused imports * Changed variable name to restart WIP test * Start of android text detection * Added text recognition to android channel * Create dart test app * Added to test app * Finished example ml vision app * Formatting * Fixed crash * Add permssions * Setup iOS side of text detector * Formatting and comments * More formattign * More More Formatting * For loops and a correction
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.