Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Use context() instead of activity() #921

Merged
merged 1 commit into from
Nov 22, 2018
Merged

Use context() instead of activity() #921

merged 1 commit into from
Nov 22, 2018

Conversation

dguralnick
Copy link
Contributor

Using activity() causes a crash if the plugin is registered before the activity.

Fixes flutter/flutter#24633

Using activity() causes a crash if the plugin is registered before the activity.

Fixes flutter/flutter#24633
@alanrussian
Copy link
Contributor

LGTM

Copy link
Contributor

@mehmetf mehmetf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. ANDROID_ID is not tied to any activity.

@mehmetf mehmetf merged commit e84d61f into flutter:master Nov 22, 2018
andreidiaconu pushed a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
Using activity() causes a crash if the plugin is registered before the activity.

Fixes flutter/flutter#24633
andreidiaconu added a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants