Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinsert Command, Control key on Get Started/Test Drive pages #10720

Closed
1 task done
kimtaejin3 opened this issue Jun 7, 2024 · 1 comment
Closed
1 task done

Reinsert Command, Control key on Get Started/Test Drive pages #10720

kimtaejin3 opened this issue Jun 7, 2024 · 1 comment
Assignees
@atsansone
Labels
a.get-started Relates to the Getting Started section of docs.flutter.dev e0-minutes Effort: < 60 min from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible.

Comments

@kimtaejin3
Copy link
Contributor

kimtaejin3 commented Jun 7, 2024 •
edited
Loading

Page URL

https://docs.flutter.dev/get-started/test-drive?tab=vscode

Page source

https://github.com/flutter/website/blob/main/src/_includes/docs/install/test-drive/vscode.md

Describe the problem

image

As you can see, the Command (Mac) / Control (Other platforms) key is omitted in the Create a sample Flutter app section.

image

It is also omitted in the Run your sample Flutter app section.

Expected fix

mac

image

Other platforms

image

Additional context

No response

I would like to fix this problem.

  • I will try and fix this problem on docs.flutter.dev.
@kimtaejin3 kimtaejin3 added the from.page-issue Reported in a reader-filed concern label Jun 7, 2024
@kimtaejin3 kimtaejin3 changed the title Command, Control key omitted on Get Started/Test Drive page [PAGE ISSUE]: Command, Control key omitted on Get Started/Test Drive page Jun 7, 2024
@kimtaejin3 kimtaejin3 mentioned this issue Jun 7, 2024
Merged
3 tasks
@atsansone atsansone changed the title [PAGE ISSUE]: Command, Control key omitted on Get Started/Test Drive page Reinsert Command, Control key on Get Started/Test Drive pages Jun 10, 2024
@atsansone atsansone self-assigned this Jun 10, 2024
@atsansone atsansone added a.get-started Relates to the Getting Started section of docs.flutter.dev p2-medium Necessary but not urgent concern. Resolve when possible. e0-minutes Effort: < 60 min labels Jun 10, 2024
sfshaza2 pushed a commit that referenced this issue Jun 10, 2024
@kimtaejin3 @taejinkim3
Fix special key omission on Get Started/Test Drive page (#10721)
d807ee4 
_Description of what this PR is changing or adding, and why:_
Command, Control key omitted on Get Started/Test Drive page

_Issues fixed by this PR (if any):_
#10720 

## Presubmit checklist

- [x] This PR doesn’t contain automatically generated corrections
(Grammarly or similar).
- [x] This PR follows the [Google Developer Documentation Style
Guidelines](https://developers.google.com/style) — for example, it
doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person).
- [x] This PR uses [semantic line
breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks)
of 80 characters or fewer.

Co-authored-by: Taejin Kim <[email protected]>
@sfshaza2
Copy link
Contributor

Fixed by #10721. Thanks, @kimtaejin3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atsansone atsansone

Labels
a.get-started Relates to the Getting Started section of docs.flutter.dev e0-minutes Effort: < 60 min from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@atsansone @sfshaza2 @kimtaejin3