-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the doc on how Flutter is architected. #11524
base: main
Are you sure you want to change the base?
Conversation
Visit the preview URL for this PR (updated for commit 7d95ef3): |
NOTE: I think the following diagram needs updating. Can you help with | ||
that, @kevmoo? Btw, this same diagram is used on | ||
https://docs.flutter.dev/platform-integration/web |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking we should remove HTML/CSS and consider adding "skwasm" to the bottom layer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thought exactly.
which uses Impeller for rendering. | ||
Flutter also embeds its own copy of Impeller as part of the engine, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reads a little awkard to me, I think it was trying to say that the copy of Skia used by flutter was different than the system Skia on Android - but there is no system Impeller.
Maybe something like "Impeller is shipped along with the application allowing..."
|
||
On the web, Flutter offers two build mode and two renderers. | ||
The two build modes are the **default** and **WebAssembly**. | ||
The two renderers are **canvaskit** and **skwasm**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a useful distinction for our users.
We have a canvas based rendered and we have two compile modes: JS and Wasm.
Everything else is implementation details, I think.
Thoughts @eyebrowsoffire @yjbanov ?
Fixes #11304
@jonahwilliams @johnmccutchan, could one of you help validate these updates? Mostly, I updated the text around Skia/Impeller. And I added a link to the new doc, "Can I use Impeller?".
@johnpryan @kevmoo, can one of you help validate the updates to the Web section? I copied some text from the updated Web renderers page, but there's more that looks suspect. Also, the architectural diagram needs updating, I believe. I'm hoping that you can help with that.