Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the doc on how Flutter is architected. #11524

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updating the doc on how Flutter is architected. #11524

wants to merge 1 commit into from

Conversation

sfshaza2
Copy link
Contributor

Fixes #11304

@jonahwilliams @johnmccutchan, could one of you help validate these updates? Mostly, I updated the text around Skia/Impeller. And I added a link to the new doc, "Can I use Impeller?".

@johnpryan @kevmoo, can one of you help validate the updates to the Web section? I copied some text from the updated Web renderers page, but there's more that looks suspect. Also, the architectural diagram needs updating, I believe. I'm hoping that you can help with that.

@sfshaza2 sfshaza2 requested review from parlough and a team as code owners December 19, 2024 22:15
@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 7d95ef3):

https://flutter-docs-prod--pr11524-arch-cqppe1g0.web.app

Comment on lines +1069 to +1071
NOTE: I think the following diagram needs updating. Can you help with
that, @kevmoo? Btw, this same diagram is used on
https://docs.flutter.dev/platform-integration/web
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking we should remove HTML/CSS and consider adding "skwasm" to the bottom layer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thought exactly.

Comment on lines +582 to +583
which uses Impeller for rendering.
Flutter also embeds its own copy of Impeller as part of the engine,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads a little awkard to me, I think it was trying to say that the copy of Skia used by flutter was different than the system Skia on Android - but there is no system Impeller.

Maybe something like "Impeller is shipped along with the application allowing..."


On the web, Flutter offers two build mode and two renderers.
The two build modes are the **default** and **WebAssembly**.
The two renderers are **canvaskit** and **skwasm**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a useful distinction for our users.

We have a canvas based rendered and we have two compile modes: JS and Wasm.

Everything else is implementation details, I think.

Thoughts @eyebrowsoffire @yjbanov ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify "Flutter architecture overview" is up to date as of 3.27
5 participants