Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration guide for flutter/flutter#49389 #3622

Merged
merged 6 commits into from
Feb 6, 2020
Merged

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Jan 29, 2020

For what it's worth, I have not been able to find any instances of people overriding ImageProvider.resolve in google3 or pub.

This is combined because the upstream change is combined. Before landing I will change the TBD to actually have the Flutter version it lands in.

@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Jan 29, 2020
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, deferring to @Sfshaza (or @sfshaza2 ??) to review for writing style :)

@@ -0,0 +1,140 @@
---
title: [Changes to ImageCache and ImageProvider]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these supposed to be in []? The one other guide I checked didn't have that...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

## Summary

`ImageCache` now has a method called `obaintsKey`. `ImageProvider` subclasses
should not override `resolve`, but instead should resolve new methods on
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should resolve -> should implement

or something like that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops - yeah.

...
}
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this missing a "Code after the migration:"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


## Timeline

TBD - will update before landing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to change this :)

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, once you add the release info!


## Summary

`ImageCache` now has a method called `obaintsKey`. `ImageProvider` subclasses
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obaintsKey => containsKey. ??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whups. Yes. There is also a method calld obtainKey, must've had a brain fart in there haha

@dnfield
Copy link
Contributor Author

dnfield commented Jan 31, 2020

Added release info.

@dnfield dnfield requested a review from sfshaza2 January 31, 2020 20:57
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@sfshaza2 sfshaza2 merged commit edb4ff8 into flutter:master Feb 6, 2020
@Gperez88
Copy link

when they move this to stable branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants