Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature-request] For android forward and backward controls like iOS #615

Closed
NikhilKukreja26 opened this issue Mar 7, 2022 · 3 comments · Fixed by #703
Closed

[feature-request] For android forward and backward controls like iOS #615

NikhilKukreja26 opened this issue Mar 7, 2022 · 3 comments · Fixed by #703
Labels
enhancement good first issue

Comments

@NikhilKukreja26
Copy link

Hello,
I am using the chewie package for android and ios for video playing. In iOS, we have forward and backward controls so anyone can forward 15 sec or backward the 15 sec but on android, it is not possible can we have a double tap on right to forward it and on the left side 15 backward.

Thank you
@diegotori
Copy link
Collaborator

@NikhilKukreja26 if you have the capacity, I always accept Pull Requests and I'll be happy to review them. In terms of the changes, they should be made where the CenterPlayButton is rendered, within MaterialControls._buildHitArea().

@NikhilKukreja26
Copy link
Author

Thank you so much @diegotori for your reply I will definitely try it if I succeed I will definitely submit my pull request.

@GyanendroKh GyanendroKh mentioned this issue Jan 28, 2023
Merged
@GyanendroKh
Copy link
Contributor

@diegotori As this issue hasn't had any activity in a while, I took the time to implement the feature just like you said and submitted a PR #703

Can you please check and merge if everything is good?
Thanks.

diegotori added a commit that referenced this issue Sep 10, 2024
@diegotori
chewie, version 1.8.5. Addresses Issue #615.
c7665a3
lg8294 added a commit to lg8294/chewie that referenced this issue Sep 13, 2024
@lg8294
Merge commit 'c7665a379343679beba9d480a8989df6f2e0499c' into github/c…
4f335a5 
…ustom-lg

* commit 'c7665a379343679beba9d480a8989df6f2e0499c':
  chewie, version 1.8.5. Addresses Issue fluttercommunity#615.
  Fixed a stray lint issue due to recent PR.
  chore: pass draggableProgressBar from chewieController.
  chore: make progress bar independent on chewie controller.
  chore: add barHeight and handleHeight properties.
  chore: export MaterialVideoProgressBar widget.
  Adding Material Seek Control button size and fade duration config
  Adding Seek buttons for Android
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding Seek buttons for Android GyanendroKh/chewie
3 participants
@diegotori @GyanendroKh @NikhilKukreja26