support for custom text property for a subtitle

[ekuleshov]

Support for custom RichText subtitles #479

[Ahmadre]

Thank you @ekuleshov for your PR!

[ekuleshov]

Thank you @ekuleshov for your PR!

You may want to reopen #479

[ekuleshov]

@Ahmadre I tried to change Subtitles and subtitleBuilder to be parametrized types like:

class Subtitles<T> {
  Subtitles(this.subtitle, { this.subtitleBuilder });

  final List<Subtitle<T>?> subtitle;
  Widget Function(BuildContext context, T subtitle)? subtitleBuilder;
  ...

The subtitle and subtitleBuilder values need to be tied together because of a common generic type, in under Subtitles class (which is basically a Typle) stored in the ChewieController instance.

Unfortunately I could not make generic types work. Getting a type case issue at runtime even without is and as.

Now I'm not sure if it is the best way to approach this.

Or perhaps maybe the subtitleBuilder could be changed to take in a Subtitle instance instead of a String. Then I could extend Subtitle class with my own fields and will be able to do my own type casting in the subtitleBulder implementation.

What do you think?

[Ahmadre]

@Ahmadre I tried to change Subtitles and subtitleBuilder to be parametrized types like:

class Subtitles<T> {

  Subtitles(this.subtitle, { this.subtitleBuilder });



  final List<Subtitle<T>?> subtitle;

  Widget Function(BuildContext context, T subtitle)? subtitleBuilder;

  ...

The subtitle and subtitleBuilder values need to be tied together because of a common generic type, in under Subtitles class (which is basically a Typle) stored in the ChewieController instance.

Unfortunately I could not make generic types work. Getting a type case issue at runtime even without is and as.

Now I'm not sure if it is the best way to approach this.

Or perhaps maybe the subtitleBuilder could be changed to take in a Subtitle instance instead of a String. Then I could extend Subtitle class with my own fields and will be able to do my own type casting in the subtitleBulder implementation.

What do you think?

thank you for your suggestions. I will have a look at it the next week. I'm on vacation :D

[Ahmadre]

LGTM @ekuleshov :) Could you please update your branch with the latest master? After that I would merge this! I really like it and I think this way we got much more flexibility!

And could you check the CI-build errors and correct them in your branch?

[ekuleshov]

LGTM

Which part? Like I said, I could not make generified variant work.

A variant with extending Subtitle turned out rather ugly. Personally I'd have preferred a variant with dynamic text.

[ekuleshov]

It seems like to make subtitles to use generic value instead of String will require generic type all the way up to the Chewie widget.

All in all, it seems like coupling subtitles into every video control implementation is too restrictive. It would be better to decouple subtitles from that and use a separate widget overlay instead. Somewhat similar to what subtitle_wrapper_package does. Then generic type only need to be specified when configuring subtitles overlay.

[Ahmadre]

I meant the actual changes with dynamic looks good!

We can do that like in the first step.

[ekuleshov]

We can do that like in the first step.

@Ahmadre okay. I re-did the variant with dynamic type. Please review

[ekuleshov]

@Ahmadre do you have a timeline on getting this change into a plugin release?