Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for provider version 6 #548

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

zbarbuto
Copy link
Contributor

@zbarbuto zbarbuto commented Sep 20, 2021

Allows Provider version 6 to be used in conjunction with Chewie.

Some libraries are starting to update to use v6 of provider (such as flutter_bloc: ^7.2.0) which throws the following error on pub get:

Because no versions of chewie match >1.2.2 <2.0.0 and chewie 1.2.2 depends on provider ^5.0.0, chewie ^1.2.2 requires provider ^5.0.0.
And because flutter_bloc >=7.2.0 depends on provider ^6.0.0, chewie ^1.2.2 is incompatible with flutter_bloc >=7.2.0.

The breaking changes in the provider changelog only talk about optional providers of which Chewie doesn't use any so it should be safe to use provider 6 with chewie. Example app still appears to work as expected with provider v6. Have added <7 to safeguard against breaking changes in future unreleased versions of Provider.

Closes #530

@charlou-aredidon
Copy link

This issue is so frustrating. Lots of plugin having the same error.

@diegotori
Copy link
Collaborator

@Ahmadre is there any update on this issue, since I too am overriding Provider to 6.0.0 in order to work around this issue.

If you need another person to release updates to this library on your behalf and/or review PRs, then I'll be glad to volunteer. Please reach out to me at [email protected], since I already have a pub.dev account.

@zbarbuto zbarbuto mentioned this pull request Oct 6, 2021
@Slaine066
Copy link

Guys please take a look at the PR when you find time.
Workarounds are painful.

@zbarbuto zbarbuto mentioned this pull request Oct 19, 2021
@diegotori
Copy link
Collaborator

@Ahmadre just a gentle reminder that this PR is awaiting approval, merging, and eventual release.

Thank you in advance.

@bhayatus
Copy link

bhayatus commented Nov 2, 2021

@Ahmadre Really hoping this PR can be approved and merged soon, can't upgrade some of our dependencies cause of this single package.

@Ahmadre Ahmadre merged commit b892cb3 into fluttercommunity:master Nov 2, 2021
@diegotori
Copy link
Collaborator

@Ahmadre can we please get another pub.dev release as a result of this change? Thanks in advance.

@FCView
Copy link

FCView commented Dec 1, 2021

@Ahmadre , any chance we can get another pub.dev release for this provider dependency update? I have several conflicts that are starting to arise due to this.

@janhelwich
Copy link

@FCView and others interested. You can reference the commit also in your pubspec.yaml like this:


  chewie: #^1.2.2
    git:
      url: https://github.com/brianegan/chewie.git
      ref: b892cb3d4cef0f5f726f97be993e4e0808895489

Not perfect but works until the next version is released.

@imtoori
Copy link

imtoori commented Dec 16, 2021

could you publish a new release, please?

@CalHoll
Copy link

CalHoll commented Jan 15, 2022

Please release!

@DaemonChoejur
Copy link

any news on when 1.2.3 will be released?

@kimmanwky
Copy link

@brianegan Please release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chewie 1.2.2 depends on provider ^5.0.0 but current provider version is ^6.0.0