Remove V1 Embed Support and Upgrade APIs #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atrope
changed the title
atrope
force-pushed
the
feature/upgradeV1
branch
from
670d64c to
3efdc1d
Compare
|
@atrope , thanks for your PR. It looks good to me. Could you resolve the conflicts? |
|
@hnvn it should be ok to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are almost 1 Year ahead of Android V2 Embed and since it provide better background support we should be ok by unsupporting old deprecated APIs.
In this PR we
Remove V1 Support by removing the registerWith method.
We upgrade from FlutterNativeView to the newer background Apis (Document old Android embedding's FlutterView migration flutter/flutter#46856 (comment)) Providing better support and performance for the plugin.
Fix the backoffdelay warning explained here: Backoff delay duration less than minimun value #39 (comment)