fix(device_info_plus): Update exports to avoid web compatibility issues #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbuberen
force-pushed
the
fix/device_info_web
branch
from
fbf0e98 to
157fe02
Compare
nohli
reviewed
Aug 15, 2023
Comment on lines
+28
to
31
| export 'src/device_info_plus_linux.dart' | ||
| if (dart.library.html) 'src/device_info_plus_web.dart'; | ||
| export 'src/device_info_plus_windows.dart' | ||
| if (dart.library.html) 'src/device_info_plus_web.dart'; |
There was a problem hiding this comment.
Can we chain two if clauses, instead of exporting the same library twice?
There was a problem hiding this comment.
No, unfortunately we can't. As far as I understand there are no issues with such export or, otherwise, we would see failing builds.
There was a problem hiding this comment.
Going to merge to release new versions in nearest time
vbuberen
force-pushed
the
fix/device_info_web
branch
from
157fe02 to
21161d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to #1651
device_info_plusmight cause some analyzer issues to other packages which use the plugin. After looking at code it looks like we already had a conditional export for windows part, so this PR adds the same condition to linux part to be sure that there are no unsupported libraries used for web (at least from package analyzer point of view).Related Issues
Fixes #1651
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).