-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(share_plus)!: Target Java 17 on Android #2730
Conversation
Since this PR I'm getting the following error when trying to build for Android:
Could you explain what kind of migration is neccesary? Do we need to upgrade to Gradle 8.4 even though it's in beta? |
You need to change your
You are confusing Android Gradle Plugin and Gradle itself. While Android Gradle Plugin 8.4 is indeed in beta, Gradle 8.4 itslef isn't in beta. We require Gradle wrapper version to be 8.4. Gradle wrapper is specified in files like this inside any project: https://github.com/fluttercommunity/plus_plugins/blob/main/packages/share_plus/share_plus/android/gradle/wrapper/gradle-wrapper.properties |
Thanks Volodymyr. I have updated to Java 17 and Gradle Wrapper 8.4. I have kept Gradle Plugin at 8.2.2 due to a bug with 8.3. Unfortunately this only replaced ther error with:
I'm not sure why, since the game_services plugin does not specify a Java or Kotlin version? link As a final result, based on this Stackoverflow post, I added |
And what about Java compile options? Did you also change it to 17 like it is done in this PR? These 2 lines are the ones responsible for Java version for Java compile: https://github.com/fluttercommunity/plus_plugins/pull/2730/files#diff-2607f8958e631dcb7f1ce17b341b8520cde253d7cde36a0bafc64d98676f4270R33 |
What is |
Yes, I did replaced the compile options with Java 17 as well. Here is the full And the settings.gradle file is: https://pastebin.com/WeXLHTab Sorry for the broken link for the game_services plugin. I've updated it above. |
Description
Same as #2723
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!
in the title as explained in Conventional Commits).