Support FantasyLand 1.x #26
Conversation
I also changed the FantasyLand dispatchers to dispatch strictly to Fantasy prefixed methods. Fixes #25.
Current coverage is 100% (diff: 100%)
|
|
I would like to ask the community whether there's anything I forgot in order to support FL-1.0? |
|
Prefixes and flipped |
| error$invalidArgument(`Future.${method}`, 0, `have a "${method}" method`, m); | ||
| }; | ||
| } | ||
|
|
There was a problem hiding this comment.
It's nice to see this go away. :)
| bimap: 'fantasy-land/bimap', | ||
| chain: 'fantasy-land/chain', | ||
| ap: 'fantasy-land/ap', | ||
| of: 'fantasy-land/of' | ||
| }; |
There was a problem hiding this comment.
I suggest adding fantasy-land as a dev dependency and requiring it here to catch typos. :)
There was a problem hiding this comment.
Ahh, that's a great idea! That way we're ensuring compatibility with the naming conventions of a specific FL version, without having a hard dependency to it! :D
There was a problem hiding this comment.
Just curious why not actually add a hard dependency?
There was a problem hiding this comment.
I mean I can understand not wanting a peer dependency, but what bad about a normal dependency?
There was a problem hiding this comment.
Just curious why not actually add a hard dependency?
I don't see compelling reasons to do so: sanctuary-js/sanctuary-type-classes#2 (comment).
There was a problem hiding this comment.
FantasyLand comes with its own dependency tree which seems to me like unnecessary overhead. It's not much of a big deal, but if there's no practical difference, or even much of a code-reuse advantage, I consider it cleaner not to depend on it.
There was a problem hiding this comment.
FantasyLand comes with its own dependency tree which seems to me like unnecessary overhead.
Didn't know that, created a PR that fixes it fantasyland/fantasy-land#168
Other points are valid as well though, I understand it better now, thanks!
| @@ -802,3 +807,4 @@ means butterfly in Romanian; A creature you might expect to see in Fantasy Land. | |||
| [22]: https://github.com/Avaq/Fluture/wiki/Comparison-to-Promises | |||
| [23]: https://vimeo.com/106008027 | |||
| [24]: https://github.com/fantasyland/fantasy-land#bifunctor | |||
| [25]: https://github.com/fantasyland/fantasy-land/tree/1.0.0 | |||
There was a problem hiding this comment.
Should this be 1.0.1?
There was a problem hiding this comment.
I wish it could be ^1.0.0, maybe I should just use master and pin it once a 2.0 comes out.
ap