-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(flux2): add variable to customise cluster domain (#139) #140
fix(flux2): add variable to customise cluster domain (#139) #140
Conversation
…y#139) * add new `clusterDomain` variable which defaults to `cluster.local` * use `clusterDomain` for source-controller `storage-adv-addr` argument * use `clusterDomain` for `events-addr` argument NOTES: The source-controller manifest included a hard-coded advertising address with `cluster.local`. In some environments, the cluster domain is modified, which broke the kustomize controller from being able to resolve the source controller to acquire artifacts. BREAKING CHANGE: The `eventsaddr` variable has been removed as it is no longer necessary. The new `clusterDomain` variable is now used to create a fully-qualified addresses throughout the deployment manifiests. Signed-off-by: Deavon M. McCaffery <[email protected]>
If we are making breaking changes I would suggest correcting the variables names, some of them are not capitalized correctly for example |
I agree. It drives me nuts. 🙃 |
Signed-off-by: Deavon M. McCaffery <[email protected]>
Signed-off-by: Deavon M. McCaffery <[email protected]>
Signed-off-by: Deavon M. McCaffery <[email protected]>
Signed-off-by: Deavon M. McCaffery <[email protected]>
Signed-off-by: Deavon M. McCaffery <[email protected]>
Signed-off-by: Deavon M. McCaffery <[email protected]>
Signed-off-by: Deavon M. McCaffery <[email protected]>
Signed-off-by: Deavon M. McCaffery <[email protected]>
Signed-off-by: Deavon M. McCaffery <[email protected]>
Signed-off-by: Deavon M. McCaffery <[email protected]>
@stefanprodan I fixed the casing of everything that I could find. I've left them each in separate commits to make them easier to review. Per the contributing guide, changes should be squashed before opening a PR, but I figured that would make this much more difficult to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @dmccaffery 🥇
clusterDomain
variable which defaults tocluster.local
clusterDomain
for source-controllerstorage-adv-addr
argumentclusterDomain
forevents-addr
argumentNOTES:
The source-controller manifest included a hard-coded advertising address with
cluster.local
. In some environments, the cluster domain is modified, which broke the kustomize controller from being able to resolve the source controller to acquire artifacts.BREAKING CHANGE:
The
eventsaddr
variable has been removed as it is no longer necessary. The newclusterDomain
variable is now used to create a fully-qualified addresses throughout the deployment manifiests.Signed-off-by: Deavon M. McCaffery [email protected]
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
make reviewable