Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flux v2.2.0: Update CRDs and component versions #204

Merged

Conversation

rsafonseca
Copy link
Contributor

@rsafonseca rsafonseca commented Dec 12, 2023

What this PR does / why we need it:

Updates the CRDs to include the latest specs, updates components to latest versions

Special notes for your reviewer:

Allows the helm-chart to be used for proper install/function of the latest component versions

Checklist

  • DCO signed
  • Chart Version bumped
  • helm-docs are updated
  • Helm chart is tested
  • Update artifacthub.io/changes in Chart.yaml
  • Run make reviewable

Signed-off-by: Rafael da Fonseca <[email protected]>
Signed-off-by: Rafael da Fonseca <[email protected]>
Signed-off-by: Rafael da Fonseca <[email protected]>
Signed-off-by: Rafael da Fonseca <[email protected]>
Signed-off-by: Rafael da Fonseca <[email protected]>
Signed-off-by: Rafael da Fonseca <[email protected]>
Signed-off-by: Rafael da Fonseca <[email protected]>
@rsafonseca rsafonseca force-pushed the helm-controller-crd-update branch from 8763ddd to 8056e13 Compare December 12, 2023 10:30
@rsafonseca
Copy link
Contributor Author

cc @stefanprodan this should help get things ready for flux v2.2.0 :)

@stefanprodan
Copy link
Member

Please hold this until we release Flux 2.2.0 then we can bump the app version here and the cli version.

@rsafonseca
Copy link
Contributor Author

Yeah, i was about to ask about bumping those since the release date is expected to be today right? :)

@stefanprodan
Copy link
Member

Yeap couple of hours from now

@stefanprodan
Copy link
Member

@rsafonseca please bump the app version and the CLI tag, we've released v2.2.0

Signed-off-by: Rafael da Fonseca <[email protected]>
@rsafonseca
Copy link
Contributor Author

all set @stefanprodan 👍

@stefanprodan stefanprodan changed the title Update CRDs and component versions Flux v2.2.0: Update CRDs and component versions Dec 12, 2023
@stefanprodan
Copy link
Member

Please bump the other charts as well

@stefanprodan
Copy link
Member

stefanprodan commented Dec 12, 2023

We also need to bump Kubernetes in CI to v1.28.0 here

node_image: kindest/node:v1.25.11

Signed-off-by: Rafael da Fonseca <[email protected]>
@rsafonseca
Copy link
Contributor Author

Done, it was actually in 2 places :)

@rsafonseca
Copy link
Contributor Author

argh, the liniting job is tying all the charts together so it's failing for the charts i didn't update :(

@stefanprodan
Copy link
Member

Please bump the chart version for flux2-notification and flux2-sync

@stefanprodan
Copy link
Member

argh, the liniting job is tying all the charts together so it's failing for the charts i didn't update :(

There is an update, the app version so chart version needs a bump too

@rsafonseca
Copy link
Contributor Author

Yeah, just noticed that as I typed it... the Makefile target did that for me hehe.. i added the notification.toolkit.fluxcd.io apiversion bump to flux2-notification chart as a bonus :)

Signed-off-by: Rafael da Fonseca <[email protected]>
@rsafonseca
Copy link
Contributor Author

It should be all green now :)

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @rsafonseca 🏅

@stefanprodan stefanprodan merged commit 059582f into fluxcd-community:main Dec 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants