Skip to content

Commit

Permalink
Update Istio to v1.3.3
Browse files Browse the repository at this point in the history
  • Loading branch information
stefanprodan committed Oct 28, 2019
1 parent f56a697 commit c9bacdf
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 10 deletions.
3 changes: 1 addition & 2 deletions pkg/controller/scheduler.go
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,6 @@ func (c *Controller) analyseCanary(r *flaggerv1.Canary) bool {

// create observer based on the mesh provider
observerFactory := c.observerFactory
observer := observerFactory.Observer(metricsProvider)

// override the global metrics server if one is specified in the canary spec
metricsServer := c.observerFactory.Client.GetMetricsServer()
Expand All @@ -763,8 +762,8 @@ func (c *Controller) analyseCanary(r *flaggerv1.Canary) bool {
c.recordEventErrorf(r, "Error building Prometheus client for %s %v", r.Spec.MetricsServer, err)
return false
}
observer = observerFactory.Observer(metricsProvider)
}
observer := observerFactory.Observer(metricsProvider)

// run metrics checks
for _, metric := range r.Spec.CanaryAnalysis.Metrics {
Expand Down
3 changes: 0 additions & 3 deletions test/container-push.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ push () {
else
docker tag test/flagger:latest weaveworks/flagger:${CIRCLE_TAG};
docker push weaveworks/flagger:${CIRCLE_TAG};
LT_VERSION=$(grep 'VERSION' cmd/loadtester/main.go | awk '{ print $4 }' | tr -d '"' | head -n1);
docker tag test/flagger-loadtester:latest weaveworks/flagger-loadtester:${LT_VERSION};
docker push weaveworks/flagger-loadtester:${LT_VERSION};
fi
}

Expand Down
3 changes: 0 additions & 3 deletions test/e2e-gloo-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@ spec:
upstreamGroup:
name: podinfo
namespace: test
routePlugins:
prefixRewrite:
prefixRewrite: "/"
EOF

cat <<EOF | kubectl apply -f -
Expand Down
2 changes: 1 addition & 1 deletion test/e2e-istio.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

set -o errexit

ISTIO_VER="1.3.0"
ISTIO_VER="1.3.3"
REPO_ROOT=$(git rev-parse --show-toplevel)
export KUBECONFIG="$(kind get kubeconfig-path --name="kind")"

Expand Down
2 changes: 1 addition & 1 deletion test/e2e-nginx-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ failed=false
until ${ok}; do
kubectl -n test get canary/podinfo | grep 'Failed' && failed=true || failed=false
if ${failed}; then
kubectl -n ingress-nginx logs deployment/test-flagger
kubectl -n ingress-nginx logs deployment/flagger
echo "Canary failed!"
exit 1
fi
Expand Down

0 comments on commit c9bacdf

Please sign in to comment.