Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more kubernetes routing tests for resource creation/updating #114

Closed
tanordheim opened this issue Mar 21, 2019 · 0 comments · Fixed by #122
Closed

Add more kubernetes routing tests for resource creation/updating #114

tanordheim opened this issue Mar 21, 2019 · 0 comments · Fixed by #122
Labels
kind/enhancement Improvement request for an existing feature

Comments

@tanordheim
Copy link
Contributor

The current kubernetes routing tests only check that the router is able to retrieve the service from the Kubernetes API; it doesn't have any tests verifying that services are created/updated when the canary is updated.

This is related to #113 where port names were introduced, and there were no tests to verify that the change in behavior was backward compatible.
@stefanprodan stefanprodan added the kind/enhancement Improvement request for an existing feature label Mar 21, 2019
stefanprodan added a commit that referenced this issue Mar 26, 2019
@stefanprodan
Reconcile ClusterIP services
98448ea 
- add svc update tests fix: #114
stefanprodan added a commit that referenced this issue Mar 26, 2019
@stefanprodan
Reconcile ClusterIP services
ddd3a82 
- add svc update tests fix: #114
@stefanprodan stefanprodan mentioned this issue Mar 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Improvement request for an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reconcile ClusterIP services and prep v0.10.0 fluxcd/flagger
2 participants
@tanordheim @stefanprodan