Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support updating primary labels/annotations after first time rollout #1042

Closed
wants to merge 1 commit into from

Conversation

kh34
Copy link
Contributor

@kh34 kh34 commented Oct 27, 2021

Implements #1032

@kh34 kh34 requested a review from stefanprodan as a code owner October 27, 2021 18:33
@daviddelucca
Copy link

@kh34 does this issue solves copy Deployment annotations when a change is triggered? I am using v1.7.0 and noticed that annotations from primary Deployment are never updated after first rollout - If I change any annotation from my canary deployment, it nevers copied to primary one.

As example. I update my canary Deployment to something like:

apiVersion: apps/v1
kind: Deployment
metadata:
  annotations:
    hpa.autoscaling.banzaicloud.io/maxReplicas: "42"
    hpa.autoscaling.banzaicloud.io/minReplicas: "13"
...
spec:  
  template:
    metadata:
      annotations:        
        my.annotat: random

Added annotation my.annot and changed value from hpa.autoscaling.banzaicloud.io/maxReplicas. Flagger triggers a new deploy but hpa.autoscaling.banzaicloud.io/maxReplicas is never updated

apiVersion: apps/v1
kind: Deployment
metadata:
  annotations:
    hpa.autoscaling.banzaicloud.io/maxReplicas: "41"
    hpa.autoscaling.banzaicloud.io/minReplicas: "13"
...
spec:  
  template:
    metadata:
      annotations:
        my.annotat: random

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants