-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] primaryReadyThreshold: allow configuring threshold for primary #1048
Conversation
9c06fd4
to
0d38a4b
Compare
Codecov Report
@@ Coverage Diff @@
## main #1048 +/- ##
=======================================
Coverage 57.15% 57.15%
=======================================
Files 76 76
Lines 6138 6139 +1
=======================================
+ Hits 3508 3509 +1
Misses 2103 2103
Partials 527 527
Continue to review full report at Codecov.
|
0d38a4b
to
8ab1c4c
Compare
@stefanprodan should I also write this for DaemonSet? |
yes please |
aae14c8
to
5cc36a0
Compare
see fluxcd#639 Signed-off-by: Mahdi Dibaiee <[email protected]>
5cc36a0
to
8f50521
Compare
@stefanprodan this is ready for review 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @mdibaiee 🥇
Thank you @stefanprodan for the prompt replies and review! |
By the end of the next week |
@stefanprodan thank you for merging! Can this be released as a new tag for us to use it from upstream, or are we waiting for some process / schedule to release a new version? |
see #639