Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
query
field to the Canary CRD and implements custom metric checks. Flagger will run the promql query, converts the result tofloat64
and compares it with the metric threshold. This allows for arbitrary Prometheus scalar queries to be used in the analysis process.Example:
The above config validates the canary by checking if the HTTP 404 req/sec percentage is below 5 percent. If the 404s rate reaches the 5% threshold the canary fails.
Failed check event:
Fix: #59
Fix: #8