Merge pull request #1806 from weaveworks/gc-mark-valid-label-value

Replace ':' with '.' in GC mark
fluxcd · Mar 7, 2019 · 1360f9b · 1360f9b
2 parents c9cda8a + e14a5f0
commit 1360f9b
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/cluster/kubernetes/sync.go b/cluster/kubernetes/sync.go
@@ -298,7 +298,8 @@ func makeGCMark(syncSetName, resourceID string) string {
 	// To prevent deleting objects with copied labels
 	// an object-specific mark is created (by including its identifier).
 	hasher.Write([]byte(resourceID))
-	return "sha256:" + base64.RawURLEncoding.EncodeToString(hasher.Sum(nil))
+	// The prefix is to make sure it's a valid (Kubernetes) label value.
+	return "sha256." + base64.RawURLEncoding.EncodeToString(hasher.Sum(nil))
 }
 
 // --- internal types for keeping track of syncing