This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Working clones occasionally balk at fetching sync tag #2169
Labels
Comments
squaremo
added
bug
blocked-needs-validation
Issue is waiting to be validated before we can proceed
labels
Jun 19, 2019
I came across this earlier, as we've had an issue with eksctl release script. As of git 2.20.0, one has to run |
hiddeco
added a commit
that referenced
this issue
Jun 25, 2019
In Git 2.20 "git fetch" was taught to forbid updates to existing tags without the "--force" option[1]. As Flux force-pushes a tag all the time to keep track of the sync state, this would sometimes lead to 'would clobber existing tag' errors while making sure a fresh checkout was up-to-date with its mirror, as described issue 2169[2]. To prevent this from happening: force fetch all tags from the mirror while creating the local working clone, and _before_ fetching anything else. NB: We only have to do this while creating a working clone from a mirror, as a mirror (bare clone) will accept non-fast-forward tag changes from remote. [1]: https://github.com/git/git/blob/master/Documentation/RelNotes/2.20.0.txt#L67-L71 [2]: #2169
hiddeco
added a commit
that referenced
this issue
Jun 25, 2019
In Git 2.20 "git fetch" was taught to forbid updates to existing tags without the "--force" option[1]. As Flux force-pushes a tag all the time to keep track of the sync state, this would sometimes lead to 'would clobber existing tag' errors while making sure a fresh checkout was up-to-date with its mirror, as described issue 2169[2]. To prevent this from happening: force fetch all tags from the mirror while creating the local working clone, and _before_ fetching anything else. NB: We only have to do this while creating a working clone from a mirror, as a mirror (bare clone) will accept non-fast-forward tag changes from remote. [1]: https://github.com/git/git/blob/master/Documentation/RelNotes/2.20.0.txt#L67-L71 [2]: #2169
hiddeco
added a commit
that referenced
this issue
Jun 25, 2019
In Git 2.20 "git fetch" was taught to forbid updates to existing tags without the "--force" option[1]. As Flux force-pushes a tag all the time to keep track of the sync state, this would sometimes lead to 'would clobber existing tag' errors while making sure a fresh checkout was up-to-date with its mirror, as described issue 2169[2]. To prevent this from happening: force fetch all tags from the mirror while creating the local working clone, and _before_ fetching anything else. NB: We only have to do this while creating a working clone from a mirror, as a mirror (bare clone) will accept non-fast-forward tag changes from remote. [1]: https://github.com/git/git/blob/master/Documentation/RelNotes/2.20.0.txt#L67-L71 [2]: #2169
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A user that has fluxd 1.12.3 connected to weave cloud occasionally sees an error message in the UI, represented in the log like this:
(NB I have anonymised the name of the ref)
I think the chain of events is something along the lines of:
The text was updated successfully, but these errors were encountered: