Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Fluxctl exposes GIT_AUTHKEY in console output #2548

Closed
janw opened this issue Oct 24, 2019 · 0 comments · Fixed by #2549
Closed

Fluxctl exposes GIT_AUTHKEY in console output #2548

janw opened this issue Oct 24, 2019 · 0 comments · Fixed by #2549
Labels

Comments

@janw
Copy link

janw commented Oct 24, 2019

Describe the bug

When using fluxctl sync the used authentication key / token is prominently displayed as part of the console output.

To Reproduce
Steps to reproduce the behaviour:

  1. Upgrade fluxd and fluxctl to 1.15.0, and set the deployment up to use Git over HTTPS
  2. Run fluxctl sync
  3. See "Synchronizing with https://…:MYTOKEN@…" as the very first line of output

Expected behavior

The authentication token should be hidden like it's done in fluxd's log output.

Logs
N/A

Additional context
Add any other context about the problem here, e.g

  • Flux version: 0.15.0
  • Helm Operator version: N/A
  • Kubernetes version: 1.15.3
  • Git provider: GitLab on premise
  • Container registry provider: GitLab on premise
@janw janw added blocked-needs-validation Issue is waiting to be validated before we can proceed bug labels Oct 24, 2019
@hiddeco hiddeco removed the blocked-needs-validation Issue is waiting to be validated before we can proceed label Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants