This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Add SafeURL helper method to GitRemoteConfig
#2549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thought: would implementing |
|
@squaremo I wasn't sure what modifications I could make to the structure without it effecting e.g. Weave Cloud or flux-web. If you think it is safe to do so, I am happy to adjust the commit. |
Hmm yeah true, it might affect serialisation. OK, we can leave that for now. |
squaremo
reviewed
Oct 24, 2019
hiddeco
force-pushed
the
fluxctl/no-https-creds-leak
branch
from
0060275 to
9925769
Compare
During the development of the (secure) Git HTTPS credential feature, I did not take the response of the `GitRepoConfig` API method into account. As a direct result, the `fluxctl sync` command still exposes the full Git URL in the logs. This commit embeds the `git.Remote` in the `GitRemoteConfig` structure, so that we can re-use the `SafeURL` helper of this structure in the `fluxctl` code. To ensure the JSON representation stays the same, a JSON struct tag has been added to the `git.Remote` URL field.
hiddeco
force-pushed
the
fluxctl/no-https-creds-leak
branch
from
9925769 to
f4a94c0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the development of the (secure) Git HTTPS credential feature,
I did not take the response of the
GitRepoConfigAPI method intoaccount. As a direct result, the
fluxctl synccommand still exposesthe full Git URL in the logs.
This commit embeds the
git.Remotein theGitRemoteConfigstructure,so that we can re-use the
SafeURLhelper of this structure in thefluxctlcode. To ensure the JSON representation stays the same, aJSON struct tag has been added to the
git.RemoteURL field.Fixes #2548