This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Log in places we might encounter an untagged image #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't expect to see untagged images from the image metadata DB, but we do. To track down #1051, this commit adds some logging to a couple of places where we would see an empty tag, as well as taking action when that happens (either aborting the cahe warming op, or skipping the automated update).
tamarakaufler
approved these changes
Apr 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't expect to see untagged images from the image metadata DB, but
we do. To track down #1051, this commit adds some logging to a couple
of places where we would see an empty tag, as well as taking action
when that happens (either aborting the cahe warming op, or skipping
the automated update).