Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Remove unused Gopkg.toml constraint #1090

Merged
merged 1 commit into from
May 21, 2018
Merged

Remove unused Gopkg.toml constraint #1090

merged 1 commit into from
May 21, 2018

Conversation

samb1729
Copy link
Contributor

Resolves this warning when running dep ensure:

Warning: the following project(s) have [[constraint]] stanzas in Gopkg.toml:

  ✗  google.golang.org/grpc

However, these projects are not direct dependencies of the current project:
they are not imported in any .go files, nor are they in the 'required' list in
Gopkg.toml. Dep only applies [[constraint]] rules to direct dependencies, so
these rules will have no effect.

Either import/require packages from these projects so that they become direct
dependencies, or convert each [[constraint]] to an [[override]] to enforce rules
on these projects, if they happen to be transitive dependencies.

Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why this [[constraint]] is here at all -- Helm is the only thing using grpc so far as I know, so many it was a problem with that at one point.

@squaremo squaremo merged commit 6689759 into fluxcd:master May 21, 2018
@samb1729 samb1729 deleted the hotfix/unused-dep-constraint branch May 21, 2018 23:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants